unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ted Zlatanov <tzz@lifelogs.com>
To: emacs-devel@gnu.org
Subject: Re: bug: epg send unencrypted data in trash
Date: Sat, 12 Feb 2011 06:56:47 -0600	[thread overview]
Message-ID: <8762spo1gw.fsf@lifelogs.com> (raw)
In-Reply-To: 87mxm285jp.fsf@stupidchicken.com

On Fri, 11 Feb 2011 19:23:06 -0500 Chong Yidong <cyd@stupidchicken.com> wrote: 

CY> I think TV is using the emacs-23 branch, where the TRASH parameter is
CY> not present.  I've changed EPA and EPG to bind delete-by-moving-to-trash
CY> to nil there.  No fix is necessary for the trunk, IIUC.

A good reason to use M-x report-emacs-bug which collects the version :)

I still don't understand the parameter definition and would appreciate
some guidance.  How does TRASH get set based on called-interactively-p,
as claimed by the docstring?

DEFUN ("delete-file", Fdelete_file, Sdelete_file, 1, 2,
       "(list (read-file-name \
                (if (and delete-by-moving-to-trash (null current-prefix-arg)) \
                    \"Move file to trash: \" \"Delete file: \") \
                nil default-directory (confirm-nonexistent-file-or-buffer)) \
              (null current-prefix-arg))",
       doc: /* Delete file named FILENAME.  If it is a symlink, remove the symlink.
If file has multiple names, it continues to exist with the other names.
TRASH non-nil means to trash the file instead of deleting, provided
`delete-by-moving-to-trash' is non-nil.

When called interactively, TRASH is t if no prefix argument is given.
With a prefix argument, TRASH is nil.  */)

I don't see anything in the body of the function to set TRASH, either.
Is it claimed because we assume `current-prefix-arg' is always null
non-interactively and `universal-arg' is always called interactively?

Thanks
Ted




  parent reply	other threads:[~2011-02-12 12:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-11  7:29 bug: epg send unencrypted data in trash Thierry Volpiatto
2011-02-11 18:16 ` Thierry Volpiatto
2011-02-11 19:54   ` Ted Zlatanov
2011-02-11 21:05     ` Thierry Volpiatto
2011-02-11 22:14       ` Ted Zlatanov
2011-02-12  0:23         ` Chong Yidong
2011-02-12  7:08           ` Thierry Volpiatto
2011-02-12 12:56           ` Ted Zlatanov [this message]
2011-02-12 18:49             ` Chong Yidong
2011-02-12 19:06               ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8762spo1gw.fsf@lifelogs.com \
    --to=tzz@lifelogs.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).