From: Lute Kamstra <Lute.Kamstra.lists@xs4all.nl>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Andy Moreton <andrewjmoreton@gmail.com>, emacs-devel@gnu.org
Subject: Re: Passing flags using vc-do-command
Date: Mon, 14 Mar 2011 16:16:35 +0100 [thread overview]
Message-ID: <8762rlenqk.fsf@speer.lan> (raw)
In-Reply-To: <jwvlj0hvmzz.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 14 Mar 2011 09:43:50 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> + (defvar vc-post-command-1-functions nil
>> + "Hook run at the end of `vc-do-command-1'.
>> + Each function is called inside the buffer in which the command
>> + was run and is passed 4 arguments: the COMMAND, the FILE-OR-LIST,
>> + the BEFORE-FLAGS and the AFTER-FLAGS.")
>
> Do we really need that?
>
>> ! (defun vc-do-command-1 (buffer okstatus command file-or-list
>> ! &optional before-flag-or-list &rest after-flags)
>
> I'd rather a nicer name for the new command.
> And I'd like it to address some of the other needs of backends,
> e.g. paying attention to vc-<backend>-program. So I think we should
> look at the calls to vc-do-command (and to
> call-process/start-process/...) in backends to try and design the
> successor to vc-do-command.
I'm open to suggestions for a better name... But maybe it's cleaner to
make an incompatible change and just replace vc-do-command. I could
change all calls to vc-do-command in trunk, but I have no idea how many
backends exist outside the emacs repository. Replacing vc-do-command
would also eliminate my need of a second hook variable. What do people
say?
I could take a look at the current uses of vc-do-command / call-process
/ start-process in the various backends in trunk to see if I can
accommodate for possible other shortcomings of the current version. But
I'd appreciate some help with that: If people could give me concrete
examples of useful additions, that would be great.
Lute
next prev parent reply other threads:[~2011-03-14 15:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 17:53 Passing flags using vc-do-command Lute Kamstra
2011-03-07 23:02 ` Stefan Monnier
2011-03-09 6:32 ` Lute Kamstra
2011-03-09 18:21 ` Stefan Monnier
2011-03-10 13:58 ` Andy Moreton
2011-03-11 1:52 ` Stefan Monnier
2011-03-12 8:40 ` Lute Kamstra
2011-03-12 8:29 ` Lute Kamstra
2011-03-14 11:35 ` Lute Kamstra
2011-03-14 13:43 ` Stefan Monnier
2011-03-14 15:16 ` Lute Kamstra [this message]
2011-03-15 2:06 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762rlenqk.fsf@speer.lan \
--to=lute.kamstra.lists@xs4all.nl \
--cc=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).