From: Chong Yidong <cyd@stupidchicken.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r105429: New function `string-mark-left-to-right' for handling LRMs.
Date: Fri, 12 Aug 2011 11:47:00 -0400 [thread overview]
Message-ID: <8762m28wej.fsf@stupidchicken.com> (raw)
In-Reply-To: <8362m3xfgz.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 12 Aug 2011 10:21:16 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> Btw, is there a way to regex-search for a character by its bidi
> category? That would make the code more elegant, and probably quite
> faster as well.
I don't think so, and anyway such a regex-search would still have to go
through the functions of mule-cmds.el. A better optimization might be
to provide the equivalents of `next-property-change' etc. for char code
properties.
In practice, testing indicates string-mark-left-to-right has acceptable
speed for its present uses in buffer menu and tabulated list mode.
Unless a real problem shows up (e.g. when we apply the fix to Gnus),
let's revisit this issue later.
>> (aref str n) 'bidi-class) '(R AL))
> ^^^^^^^
> Make that '(R AL RLO), since the RLO character overrides the
> bidirectional properties of all the following characters with R.
OK, committed along with doc changes.
>> then the buffer is displayed as 1>[some Arabic text]>, both in the
>> mode-line and in the buffer menu.
>
> I didn't mean the display of the buffer name itself; that is a
> separate issue, as discussed here:
Was there any resolution on that thread?
next prev parent reply other threads:[~2011-08-12 15:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1QrEHF-0003qX-I0@vcs.savannah.gnu.org>
2011-08-11 2:14 ` [Emacs-diffs] /srv/bzr/emacs/trunk r105429: New function `string-mark-left-to-right' for handling LRMs Stefan Monnier
2011-08-11 3:02 ` Eli Zaretskii
2011-08-11 4:48 ` Eli Zaretskii
2011-08-11 19:01 ` Chong Yidong
2011-08-12 7:21 ` Eli Zaretskii
2011-08-12 15:47 ` Chong Yidong [this message]
2011-08-12 15:54 ` Eli Zaretskii
2011-08-12 16:00 ` Chong Yidong
2011-08-12 17:25 ` Eli Zaretskii
2011-08-13 7:00 ` Kenichi Handa
2011-08-13 7:11 ` Eli Zaretskii
2011-08-13 7:42 ` Kenichi Handa
2011-08-13 13:53 ` Stefan Monnier
2011-08-14 16:21 ` Chong Yidong
2011-08-16 7:44 ` Eli Zaretskii
2011-08-16 23:57 ` Kenichi Handa
2011-08-17 5:49 ` Eli Zaretskii
2011-08-17 7:21 ` Kenichi Handa
2011-08-17 9:15 ` Eli Zaretskii
2011-08-18 2:13 ` Kenichi Handa
2011-08-17 21:12 ` Chong Yidong
2011-08-18 7:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762m28wej.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).