unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: emacs-devel@gnu.org
Subject: Re: Recommend move eshell/su and eshell/sudo to em-tramp.el
Date: Wed, 04 Jul 2012 16:53:17 +0200	[thread overview]
Message-ID: <8762a3r31e.fsf@gmx.de> (raw)
In-Reply-To: <m2r4ssiq4r.fsf@newartisans.com> (John Wiegley's message of "Tue,  03 Jul 2012 14:47:00 -0500")

"John Wiegley" <johnw@newartisans.com> writes:

> This type of behavior, being that it is special, really deserves to be in its
> own "opt-in" module.  It's better to educate people how to turn on behavior
> that may have surprising consequences, rather than to make it the default and
> then educate them how to disable it.

Understood. Maybe we should change it such a way, that plain sudo is
called when your default directory is local. This is what people expect.

> Also, eshell/sudo does not fit with the philosophy of the other
> functions in em-unix.el.  Every other function in that file provides a
> *pure Lisp* implementation of an equivalent Unix command.  As far as I
> can see, both *sudo and eshell/sudo end up calling /usr/bin/sudo.
> sehell/sudo is not pure Lisp (i.e., it involves an external command).
> So I'm not sure what benefit eshell/sudo gains, since ultimately it
> does the same thing, only slower and with blocking I/O?

The idea behind eshell/sudo (and eshell/su) is

- Allow su(do) to run lisp commands. "sudo ls" would call the Lisp
  implementation of ls, not the UNIX ls .

- Allow su(do) on remote hosts. On the fly, tramp-default-proxies-alist
  is expanded, in order to apply sudo on that remote host, and not on
  the local host.

Two new features, which weren't in eshell before (IIRC). 

> Other than that, you know I'm a huge Tramp fan, and I use Tramp+eshell quite
> often.  I'm very interested in seeing this work progress, albeit in its own
> module.

I agree with you that we shall not surprise people, especially when
calling sudo for local machine purposes. OTOH,  I'd love to have a kind
of automagic to let it work on remote machines. Opt-in modules need time
and courage to discover.

> Thanks,
>   John

Best regards, Michael.



  reply	other threads:[~2012-07-04 14:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-02 19:25 Recommend move eshell/su and eshell/sudo to em-tramp.el John Wiegley
2012-07-03  6:56 ` Michael Albinus
2012-07-03 19:47   ` John Wiegley
2012-07-04 14:53     ` Michael Albinus [this message]
2012-07-10 12:22   ` Michael Albinus
2012-07-10 16:57     ` John Wiegley
2012-07-10 18:56       ` Michael Albinus
2012-07-11  3:57         ` John Wiegley
  -- strict thread matches above, loose matches on Subject: below --
2012-06-29  3:32 John Wiegley
2012-06-29  9:45 ` Michael Albinus
2012-06-29 21:51 ` Phil Hagelberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8762a3r31e.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).