unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: David Engster <deng@randomsample.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Byte compiler and eval-when-compile
Date: Thu, 18 Oct 2012 20:55:57 +0200	[thread overview]
Message-ID: <876267zk1u.fsf@engster.org> (raw)
In-Reply-To: <jwvehkzz15p.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 15 Oct 2012 20:58:27 -0400")

Stefan Monnier writes:
>>> Actually, it just recovered the smartness I added many years ago and
>>> which got broken years ago as well.
>> Just to make sure I understand this right: the byte-compiler will now
>> bark if you're using functions (instead of just macros and defsubsts)
>> from eval-when-compile'd required packages?
>
> Yes, at least that's the intention: IIRC the implementation is pretty
> approximate, so it may very well miss some such functions and complain
> about unjustified ones.

Could you maybe take a look at the end of eieio.el? I don't understand
why the compiler warns that `eieio-update-lisp-imenu-expression' is
undefined (he actually always did that, not only since your last
change). I'm also not sure what's the fix here - why did you wrap the
check for (boundp 'lisp-imenu-generic-expression) in an
`eval-when-compile'?

[It's not really important, but I'm curious. :-) ]

-David



  reply	other threads:[~2012-10-18 18:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-15 16:23 Byte compiler and eval-when-compile David Engster
2012-10-15 18:41 ` Stefan Monnier
2012-10-15 19:26   ` David Engster
2012-10-16  0:58     ` Stefan Monnier
2012-10-18 18:55       ` David Engster [this message]
2012-10-18 19:53         ` Glenn Morris
2012-10-18 20:07           ` David Engster
2012-10-18 20:11           ` Glenn Morris
2012-10-18 20:15             ` David Engster
2012-10-19  0:38         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=876267zk1u.fsf@engster.org \
    --to=deng@randomsample.de \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).