From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Michael Albinus <michael.albinus@gmx.de>
Newsgroups: gmane.emacs.devel
Subject: Re: [Emacs-diffs] trunk r113896: Declare external variables.
Date: Fri, 16 Aug 2013 14:46:34 +0200
Message-ID: <8761v5erbp.fsf@gmx.de>
References: <E1VA0wJ-0001uE-N7@vcs.savannah.gnu.org>
	<jwv8v02ae88.fsf-monnier+emacs@gnu.org>
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain
X-Trace: ger.gmane.org 1376657214 12516 80.91.229.3 (16 Aug 2013 12:46:54 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Fri, 16 Aug 2013 12:46:54 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Stefan Monnier <monnier@iro.umontreal.ca>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 16 14:46:56 2013
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1VAJQd-000322-Pr
	for ged-emacs-devel@m.gmane.org; Fri, 16 Aug 2013 14:46:55 +0200
Original-Received: from localhost ([::1]:58673 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1VAJQd-0002Si-AC
	for ged-emacs-devel@m.gmane.org; Fri, 16 Aug 2013 08:46:55 -0400
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50216)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <michael.albinus@gmx.de>) id 1VAJQV-0002SL-09
	for emacs-devel@gnu.org; Fri, 16 Aug 2013 08:46:52 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <michael.albinus@gmx.de>) id 1VAJQP-0002HQ-5Z
	for emacs-devel@gnu.org; Fri, 16 Aug 2013 08:46:46 -0400
Original-Received: from mout.gmx.net ([212.227.15.19]:53236)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <michael.albinus@gmx.de>) id 1VAJQO-0002H7-RM
	for emacs-devel@gnu.org; Fri, 16 Aug 2013 08:46:41 -0400
Original-Received: from detlef.gmx.de ([91.41.136.123]) by mail.gmx.com (mrgmx001)
	with ESMTPS (Nemesis) id 0McVGq-1VRypi2t1s-00HeIR for
	<emacs-devel@gnu.org>; Fri, 16 Aug 2013 14:46:39 +0200
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)
X-Provags-ID: V03:K0:s3yhHs0A+AY+4si3vnUiq4gCgZhrnMhTM50eO3PRxksWWVulLkq
	zxNblZArQ5vJMKNd+ZCBc5syz6JJ95pBUaCbC1N5Bzv7B6oEXLR62Z/mvOVgE0HfY2fKz2Y
	NL8y96/lyAx+aGLSNrth4vDr+yMN6LxwpAC3hFmJwDrsUTQwZCJDiQBx3rVqcL/hr8qItIt
	svnq1XKZZI48hdkTIxj/g==
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic]
X-Received-From: 212.227.15.19
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:162805
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/162805>

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> +  (defvar buffer-name)
>
> This is bad: buffer-name should not be a dynamically-scoped variable.

I don't like it either. It's old code, maybe it came in for whatever
compatibility reason. Don't remember.

Anyway, I've fixed it. It's not the most important part of Tramp, it is
the code reporting Tramp bugs.

>         Stefan

Best regards, Michael.