* Re: [Emacs-diffs] master 38bb639 1/2: * files.el (directory-files-recursively): Do not include remote file names.
[not found] ` <E1YAK1k-0007L6-8P@vcs.savannah.gnu.org>
@ 2015-01-12 5:17 ` Stefan Monnier
2015-01-12 9:46 ` Michael Albinus
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Monnier @ 2015-01-12 5:17 UTC (permalink / raw)
To: emacs-devel; +Cc: Michael Albinus
> + * files.el (directory-files-recursively): Do not include
> + superfluous remote file names.
I kind of see why you'd want to do that, but do you have a concrete case
where including those "superfluous" names is an actual problem?
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Emacs-diffs] master 38bb639 1/2: * files.el (directory-files-recursively): Do not include remote file names.
2015-01-12 5:17 ` [Emacs-diffs] master 38bb639 1/2: * files.el (directory-files-recursively): Do not include remote file names Stefan Monnier
@ 2015-01-12 9:46 ` Michael Albinus
2015-01-12 15:18 ` Stefan Monnier
0 siblings, 1 reply; 8+ messages in thread
From: Michael Albinus @ 2015-01-12 9:46 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> + * files.el (directory-files-recursively): Do not include
>> + superfluous remote file names.
>
> I kind of see why you'd want to do that, but do you have a concrete case
> where including those "superfluous" names is an actual problem?
I've stumbled on the problem when exploring `directory-files-recursively'.
(directory-files-recursively "/" "")
> Stefan
Best regards, Michael.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Emacs-diffs] master 38bb639 1/2: * files.el (directory-files-recursively): Do not include remote file names.
2015-01-12 9:46 ` Michael Albinus
@ 2015-01-12 15:18 ` Stefan Monnier
2015-01-12 15:46 ` Michael Albinus
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Monnier @ 2015-01-12 15:18 UTC (permalink / raw)
To: Michael Albinus; +Cc: emacs-devel
>>> + * files.el (directory-files-recursively): Do not include
>>> + superfluous remote file names.
>> I kind of see why you'd want to do that, but do you have a concrete case
>> where including those "superfluous" names is an actual problem?
> I've stumbled on the problem when exploring `directory-files-recursively'.
>
> (directory-files-recursively "/" "")
What problem happens when you do that?
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Emacs-diffs] master 38bb639 1/2: * files.el (directory-files-recursively): Do not include remote file names.
2015-01-12 15:18 ` Stefan Monnier
@ 2015-01-12 15:46 ` Michael Albinus
2015-01-15 15:14 ` Stefan Monnier
0 siblings, 1 reply; 8+ messages in thread
From: Michael Albinus @ 2015-01-12 15:46 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> I've stumbled on the problem when exploring `directory-files-recursively'.
>>
>> (directory-files-recursively "/" "")
>
> What problem happens when you do that?
It tries to open remote connections. Doesn't happen it for you, when you
comment the line I have added?
Well, it doesn't happen when calling just "emacs -Q". Tramp must be
loaded. I can reproduce it with "emacs -Q -l tramp".
> Stefan
Best regards, Michael.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Emacs-diffs] master 38bb639 1/2: * files.el (directory-files-recursively): Do not include remote file names.
2015-01-12 15:46 ` Michael Albinus
@ 2015-01-15 15:14 ` Stefan Monnier
2015-01-16 15:33 ` Michael Albinus
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Monnier @ 2015-01-15 15:14 UTC (permalink / raw)
To: Michael Albinus; +Cc: emacs-devel
>>> I've stumbled on the problem when exploring `directory-files-recursively'.
>>> (directory-files-recursively "/" "")
>> What problem happens when you do that?
> It tries to open remote connections.
Is it a real problem? I mean, in which circumstance did you end up
doing (directory-files-recursively "/" "")?
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Emacs-diffs] master 38bb639 1/2: * files.el (directory-files-recursively): Do not include remote file names.
2015-01-15 15:14 ` Stefan Monnier
@ 2015-01-16 15:33 ` Michael Albinus
2015-01-16 16:38 ` Stefan Monnier
0 siblings, 1 reply; 8+ messages in thread
From: Michael Albinus @ 2015-01-16 15:33 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
> Is it a real problem? I mean, in which circumstance did you end up
> doing (directory-files-recursively "/" "")?
I wanted to explore the new directory-files-recursively, and it was the
first test which came to my mind. The shortest one to type.
It is a corner case only, of course. Do you believe my patch hurts? It's
just one line, w/o performance penalties.
> Stefan
Best regards, Michael.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Emacs-diffs] master 38bb639 1/2: * files.el (directory-files-recursively): Do not include remote file names.
2015-01-16 15:33 ` Michael Albinus
@ 2015-01-16 16:38 ` Stefan Monnier
2015-01-16 19:38 ` Michael Albinus
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Monnier @ 2015-01-16 16:38 UTC (permalink / raw)
To: Michael Albinus; +Cc: emacs-devel
>> Is it a real problem? I mean, in which circumstance did you end up
>> doing (directory-files-recursively "/" "")?
> I wanted to explore the new directory-files-recursively, and it was the
> first test which came to my mind. The shortest one to type.
So you didn't like the behavior, but it's not like that behavior was
non-sensical.
> It is a corner case only, of course. Do you believe my patch hurts? It's
> just one line, w/o performance penalties.
The problem with the patch is that you now have an ad-hoc workaround for
Tramp inside an otherwise perfectly generic function. If it's really
needed, we can live with it and it's not the end of the world, but it
seems that the need for it is not very strong, so I'm leaning towards
removing it.
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Emacs-diffs] master 38bb639 1/2: * files.el (directory-files-recursively): Do not include remote file names.
2015-01-16 16:38 ` Stefan Monnier
@ 2015-01-16 19:38 ` Michael Albinus
0 siblings, 0 replies; 8+ messages in thread
From: Michael Albinus @ 2015-01-16 19:38 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
> The problem with the patch is that you now have an ad-hoc workaround for
> Tramp inside an otherwise perfectly generic function. If it's really
> needed, we can live with it and it's not the end of the world, but it
> seems that the need for it is not very strong, so I'm leaning towards
> removing it.
No problem, you're the maintainer. Do you add a comment?
> Stefan
Best regards, Michael.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-01-16 19:38 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150111150204.28178.44482@vcs.savannah.gnu.org>
[not found] ` <E1YAK1k-0007L6-8P@vcs.savannah.gnu.org>
2015-01-12 5:17 ` [Emacs-diffs] master 38bb639 1/2: * files.el (directory-files-recursively): Do not include remote file names Stefan Monnier
2015-01-12 9:46 ` Michael Albinus
2015-01-12 15:18 ` Stefan Monnier
2015-01-12 15:46 ` Michael Albinus
2015-01-15 15:14 ` Stefan Monnier
2015-01-16 15:33 ` Michael Albinus
2015-01-16 16:38 ` Stefan Monnier
2015-01-16 19:38 ` Michael Albinus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).