From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: libnettle/libhogweed WIP Date: Mon, 17 Apr 2017 13:34:00 -0400 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <8760i3ueev.fsf@lifelogs.com> References: <83a89gq3us.fsf@gnu.org> <87bmtjiv0w.fsf_-_@lifelogs.com> <83o9xjn06c.fsf@gnu.org> <87shmeb5ln.fsf_-_@lifelogs.com> <83y3w5z1ez.fsf@gnu.org> <87lgr6yakj.fsf@lifelogs.com> <87wpamww9k.fsf@lifelogs.com> <8337daggnj.fsf@gnu.org> <87d1cdwxt6.fsf@lifelogs.com> <83tw5pg1q3.fsf@gnu.org> <87zifhulc2.fsf@lifelogs.com> <83h91og80k.fsf@gnu.org> <87pogbuhoe.fsf@lifelogs.com> <834lxndmd9.fsf@gnu.org> <87efwrug6z.fsf@lifelogs.com> <831ssrdkmz.fsf@gnu.org> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1492450496 6228 195.159.176.226 (17 Apr 2017 17:34:56 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Apr 2017 17:34:56 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 17 19:34:50 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0AY4-0001Tb-AM for ged-emacs-devel@m.gmane.org; Mon, 17 Apr 2017 19:34:48 +0200 Original-Received: from localhost ([::1]:38034 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0AYA-0002q7-7r for ged-emacs-devel@m.gmane.org; Mon, 17 Apr 2017 13:34:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0AXT-0002oo-OV for emacs-devel@gnu.org; Mon, 17 Apr 2017 13:34:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d0AXS-0006q7-Ud for emacs-devel@gnu.org; Mon, 17 Apr 2017 13:34:11 -0400 Original-Received: from [195.159.176.226] (port=33528 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d0AXS-0006pr-OK for emacs-devel@gnu.org; Mon, 17 Apr 2017 13:34:10 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1d0AXJ-0000aL-A0 for emacs-devel@gnu.org; Mon, 17 Apr 2017 19:34:01 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 32 Original-X-Complaints-To: usenet@blaine.gmane.org X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Cancel-Lock: sha1:jgy4ONH8yFKifel1lRDDD2zQ0tQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214085 Archived-At: On Mon, 17 Apr 2017 20:11:32 +0300 Eli Zaretskii wrote: EZ> Using SAFE_ALLOCA is not complicated, either. OK, thanks for the advice. Here's the output when I used it (also pushed to the branch). Let me know if I'm doing something wrong, or should go ahead and silence the warnings: USE_SAFE_ALLOCA; unsigned char *storage = SAFE_ALLOCA (storage_length); gnutls.c: In function ‘gnutls_symmetric_aead’: gnutls.c:1839:45: warning: pointer targets in passing argument 1 of ‘make_unibyte_string’ differ in signedness [-Wpointer-sign] Lisp_Object output = make_unibyte_string (storage, storage_length); ^~~~~~~ In file included from gnutls.c:23:0: lisp.h:3583:20: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern Lisp_Object make_unibyte_string (const char *, ptrdiff_t); ^~~~~~~~~~~~~~~~~~~ In file included from gnutls.c:23:0: lisp.h:4425:47: warning: variable ‘sa_must_free’ set but not used [-Wunused-but-set-variable] ptrdiff_t sa_count = SPECPDL_INDEX (); bool sa_must_free = false ^ gnutls.c:1769:3: note: in expansion of macro ‘USE_SAFE_ALLOCA’ USE_SAFE_ALLOCA; ^~~~~~~~~~~~~~~ lisp.h:4425:13: warning: unused variable ‘sa_count’ [-Wunused-variable] ptrdiff_t sa_count = SPECPDL_INDEX (); bool sa_must_free = false ^ gnutls.c:1769:3: note: in expansion of macro ‘USE_SAFE_ALLOCA’ USE_SAFE_ALLOCA; ^~~~~~~~~~~~~~~