unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-devel@gnu.org
Subject: Re: if-let/if-let*/and-let/..
Date: Tue, 13 Feb 2018 13:57:27 -0800	[thread overview]
Message-ID: <876070a6yg.fsf@ericabrahamsen.net> (raw)
In-Reply-To: 87inb0r4oe.fsf@web.de

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Mark Oteiza <mvoteiza@udel.edu> writes:
>
>> If we are ok with breaking code that depends on the special case (SYMBOL
>> VALUEFORM) semantics that the original if-let and when-let had, that is:
>>
>>   (when-let (a 1) a)
>>
>> then we could just make them aliases--they are separate from the
>> {if,when}-let* simply to avoid breaking code.
>
> Ah, that was the reason.  I'm not sure whether breaking this would be
> less bad than what we have currently.
>
> BTW, these forms don't seem to be used inside Emacs, but two files in
> Gnu Elpa use them:
>
> #+begin_src emacs-lisp
> ;;; *** /home/micha/software/elpa/packages/ebdb/ebdb.el  (1 match)
>
> ;;;; Line 5461
> (cl-defmethod ebdb-record-search ((record ebdb-record)
> 				  (_type (subclass ebdb-field-notes))
> 				  (regexp string))
>   (if-let (notes (slot-value record 'notes))
>       (ebdb-field-search notes regexp)))

Are you sure about this? In both my github repo and in the installed
version of EBDB, I've gone back to a pokey old when-inside-a-let,
precisely because of all the funkiness surrounding these macros. IIRC, I
treated the above use of `if-let' as a bug when I noticed it. I thought
I got rid of it quite a while ago...?




  reply	other threads:[~2018-02-13 21:57 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-11 23:51 if-let/if-let*/and-let/ Stefan Monnier
     [not found] ` <87wozijhpk.fsf@web.de>
     [not found]   ` <jwv8tbyyx4x.fsf-monnier+emacs@gnu.org>
2018-02-12 17:32     ` if-let/if-let*/and-let/ Stefan Monnier
2018-02-13 18:23       ` if-let/if-let*/and-let/ Michael Heerdegen
2018-02-13 19:24         ` if-let/if-let*/and-let/ Stefan Monnier
2018-02-13 20:52           ` if-let/if-let*/and-let/ John Wiegley
2018-02-13 19:31         ` if-let/if-let*/and-let/ Mark Oteiza
2018-02-13 20:49           ` if-let/if-let*/and-let/ Stefan Monnier
2018-02-14  0:07             ` if-let/if-let*/and-let/ Mark Oteiza
2018-02-14 23:07               ` if-let/if-let*/and-let/ Michael Heerdegen
2018-02-15  3:37                 ` if-let/if-let*/and-let/ Stefan Monnier
2018-02-21  4:26                   ` if-let/if-let*/and-let/ Michael Heerdegen
2018-02-22  1:08                   ` if-let/if-let*/and-let/ Michael Heerdegen
2018-02-22  5:10                     ` if-let/if-let*/and-let/ Stefan Monnier
2018-02-22  7:55                       ` if-let/if-let*/and-let/ Michael Heerdegen
2018-03-03 14:12                         ` if-let/if-let*/and-let/ Michael Heerdegen
2018-03-06 15:03                           ` if-let/if-let*/and-let/ Michael Heerdegen
2018-03-06 15:31                             ` if-let/if-let*/and-let/ Michael Heerdegen
2018-03-06 15:34                               ` if-let/if-let*/and-let/ John Wiegley
2018-03-06 16:03                                 ` if-let/if-let*/and-let/ Stefan Monnier
2018-03-06 17:40                                   ` if-let/if-let*/and-let/ Michael Heerdegen
2018-03-06 19:12                                     ` if-let/if-let*/and-let/ Radon Rosborough
2018-03-07  2:13                                       ` if-let/if-let*/and-let/ James Nguyen
2018-03-07  3:42                                         ` if-let/if-let*/and-let/ Kaushal Modi
2018-03-06 17:40                                   ` if-let/if-let*/and-let/ Eli Zaretskii
2018-03-07 14:15                                     ` if-let/if-let*/and-let/ Michael Heerdegen
2018-03-07 15:13                                       ` if-let/if-let*/and-let/ Nicolas Petton
2018-03-07 20:43                                       ` if-let/if-let*/and-let/ John Wiegley
2018-03-08 13:53                                       ` if-let/if-let*/and-let/ Eli Zaretskii
2018-03-09 15:16                                         ` if-let/if-let*/and-let/ Michael Heerdegen
2018-03-09 15:32                                           ` if-let/if-let*/and-let/ Eli Zaretskii
2018-03-09 16:07                                             ` if-let/if-let*/and-let/ Michael Heerdegen
2018-03-09 16:24                                               ` if-let/if-let*/and-let/ Eli Zaretskii
2018-03-09 16:33                                                 ` if-let/if-let*/and-let/ Michael Heerdegen
2018-03-09 18:22                                                   ` if-let/if-let*/and-let/ Eli Zaretskii
2018-03-09 22:24                                                     ` if-let/if-let*/and-let/ Michael Heerdegen
2018-03-10  8:02                                                       ` if-let/if-let*/and-let/ Eli Zaretskii
2018-03-10 15:54                                                         ` if-let/if-let*/and-let/ Stefan Monnier
2018-03-10 16:07                                                         ` if-let/if-let*/and-let/ Michael Heerdegen
2018-03-10 16:29                                                           ` if-let/if-let*/and-let/ Eli Zaretskii
2018-03-10 17:16                                                             ` if-let/if-let*/and-let/ Michael Heerdegen
2018-03-10 17:29                                                               ` if-let/if-let*/and-let/ Eli Zaretskii
2018-03-06 16:04                                 ` if-let/if-let*/and-let/ Eli Zaretskii
2018-03-06 17:35                                   ` if-let/if-let*/and-let/ Michael Heerdegen
2018-02-13 20:54           ` if-let/if-let*/and-let/ Michael Heerdegen
2018-02-13 21:57             ` Eric Abrahamsen [this message]
2018-02-13 22:39               ` if-let/if-let*/and-let/ Michael Heerdegen
2018-02-13 22:51                 ` if-let/if-let*/and-let/ Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=876070a6yg.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).