From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: emacs-26 c87d04e: Avoid aborts in 'md5' Date: Wed, 28 Feb 2018 10:09:25 +0100 Message-ID: <87606h5vlm.fsf@gmx.de> References: <20180227164448.16622.42058@vcs0.savannah.gnu.org> <20180227164448.E4B45207B1@vcs0.savannah.gnu.org> <87h8q15xdo.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1519808870 30855 195.159.176.226 (28 Feb 2018 09:07:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Feb 2018 09:07:50 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 28 10:07:45 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqxiD-0007lc-NH for ged-emacs-devel@m.gmane.org; Wed, 28 Feb 2018 10:07:45 +0100 Original-Received: from localhost ([::1]:42945 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqxkF-0000h1-U3 for ged-emacs-devel@m.gmane.org; Wed, 28 Feb 2018 04:09:51 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqxjz-0000dA-27 for emacs-devel@gnu.org; Wed, 28 Feb 2018 04:09:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqxjt-0006V0-Vf for emacs-devel@gnu.org; Wed, 28 Feb 2018 04:09:35 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:40919) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eqxjt-0006UU-Ls; Wed, 28 Feb 2018 04:09:29 -0500 Original-Received: from detlef.gmx.de ([212.86.59.154]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LZhoi-1eRmPL1tim-00lSsR; Wed, 28 Feb 2018 10:09:27 +0100 In-Reply-To: (Andreas Schwab's message of "Wed, 28 Feb 2018 09:49:36 +0100") X-Provags-ID: V03:K0:u31PPRe+TfRyXtOOvPPhE2mUv0yJ11s5yUawClJTlO8femVoGKw Wt1oZppV4WiV/LotgQP/B726XfEWIX343L43cNa4danHC3h3VDDl1wjUh8DEKgqDNQuGodK 9r+D44lAkgEyybonkLfcTwSXqvfDPP4yT83TVc1lqskJ701YPIQTHbqlajjIjwb+Qr68WYw EaWUd9jmcwlQhKaIuV4yw== X-UI-Out-Filterresults: notjunk:1;V01:K0:7Alm9m7GcUQ=:VUNY5ZTlxLEyWt/jLPEOI3 MAFlts1Bw1rRQ51dYMRO3sudga/8WSUMLt21rcW+B24Eg19D5DPlRDMRuPA/cL3Z0Qd6wmdxn VCPH5QTkfCZNtb1SmsWoo/nFzls0v3QBOE0ydJpEw4s94Rxd/khxaFDKKXQv2dyWEI1+/7h/D j4Qr1lVGnsfRotVo4TNLzFpZKke3iUMbzXvudS6TMh4pbOBOp6l1oX1TvJsJ2ltuJ/R4cIica Mw8ZeRt7FHb/3eAX/f4OsVPKH38WIfjZpN1Z7iKhCpxyVsbwUIxezGJPD63uCTmk7XeR/4HjY GlfaGH2TG95VPuZs+umoyR/WJwU11doZQcjZzRUqXfmIe+vt2Qv4or2D7Rzrb4x1MDfnJexMX qIUNev4u/I+l3MzN+n1mt91P1xnQy5HXsD2bIm63+gpcvJvSW7CMaJHMVujmsiu8rPr7Sc0QQ BUF3jU4STDwv9QVWJUK6zPG/U+Wn3I99rapDcmh//Kbfu3raURT/6l+oTcj68x2s0vhEPWQn3 qC72wFzpYV/QYEWpYTO4YMGyyZkS0At73pxpo4SAqP0iI7xZfkCkMqZcL7nHGXkUCI7veDpZu BO/QngPNlgW+JeL5zmN2/ALu3fp8xitekY2vNasFrjDObhznOyh+QIRSXzx6mKP80g7XpAJUB GkFNWdc0mCFshynfyZhlwm5WSG1sMHcbmsRBXvIy+j/pShV5q9PX4jflZXCX+Mr1HjajzoEVm tdEEaKxzzFmunCgSDsaGUoL9J5IKnrwPWBZ8IVnBUhdf3elUeW9Rw9tvGWlS67KZmcoTI66p X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.15.18 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223161 Archived-At: Andreas Schwab writes: > On Feb 28 2018, Michael Albinus wrote: > >> eliz@gnu.org (Eli Zaretskii) writes: >> >>> diff --git a/src/fns.c b/src/fns.c >>> index aba34fd..de1dad3 100644 >>> --- a/src/fns.c >>> +++ b/src/fns.c >>> @@ -4952,6 +4952,9 @@ extract_data_from_object (Lisp_Object spec, >>> #endif >>> } >>> >>> + if (!STRINGP (object)) >>> + signal_error ("Invalid object argument", >>> + NILP (object) ? build_string ("nil") : object); >>> return SSDATA (object); >>> } >> >> Don't we call CHECK_STRING (object) in such cases, which raises the >> standardized error Qwrong_type_argument? > > How can that ever happen anyway? See bug#30627. > Andreas. Best regards, Michael.