From: Tassilo Horn <tsdh@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [ELPA] New package proposal: visual-path-abbrev.el
Date: Tue, 05 Mar 2019 19:32:26 +0100 [thread overview]
Message-ID: <875zsx18at.fsf@gnu.org> (raw)
In-Reply-To: <83va0xcmwl.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 05 Mar 2019 18:21:30 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> although it's a bit sluggish when, e.g., pressing and holding C-n in
>> a *grep* buffer in column 1 (which is probably the worst case).
>>
>> I haven't yet debugged what's the slow part but I guess it is the new
>> predicate `visual-file-name-abbrev--abbrev-visually-shorter-p' which
>> ensures that the abbreviation is only displayed if it is visually
>> shorter than the normal file name, i.e., it takes into account the
>> current font and the replacement ellipsis. The standard one … is
>> twice as wide as a "normal" character on a non-terminal frame.
>
> It is, of course, best to make functions on post-command-hook as
> speedy as possible. But don't be surprised if you find out that is
> not the main reason for the sluggishness: you've just disabled a very
> important redisplay optimization, so you should expect some hit on the
> responsiveness front. These optimizations are there for a reason,
> even in these days of super-fast CPUs.
Right. In my case, I just need that for the optional (but
default-enabled) "display normally if point is on the overlay" feature.
So the post-command-hook function could check if it is enabled and do
nothing if it's not. Or it could even remove itself from p-c-h. (But
then, it wouldn't start working in that buffer if the feature was later
enabled (which is just adding a function to a list)).
>> Other than that, do you think it's ok to add this package to ELPA? If
>> so, is the (C) FSF and "This file is part of GNU Emacs" correct for an
>> ELPA(-only) package?
>
> I'll let Stefan answer this. And I believe we have recently started
> asking contributors to say explicitly in email or in the file that
> they contribute the package to Emacs, for legal purposes. So please
> do.
Ok, great. Then let's hear what he has to say.
Bye,
Tassilo
next prev parent reply other threads:[~2019-03-05 18:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 11:05 [ELPA] New package proposal: visual-path-abbrev.el Tassilo Horn
2019-03-02 11:34 ` Eli Zaretskii
2019-03-02 14:59 ` Tassilo Horn
2019-03-03 9:46 ` Tassilo Horn
2019-03-03 13:48 ` Stefan Monnier
2019-03-03 15:11 ` Eli Zaretskii
2019-03-03 15:52 ` Tassilo Horn
2019-03-03 17:18 ` Eli Zaretskii
2019-03-03 17:55 ` Tassilo Horn
2019-03-04 18:03 ` Eli Zaretskii
2019-03-05 10:01 ` Tassilo Horn
2019-03-05 16:21 ` Eli Zaretskii
2019-03-05 18:32 ` Tassilo Horn [this message]
2019-03-08 5:49 ` Stefan Monnier
2019-03-08 14:02 ` Tassilo Horn
2019-03-08 17:34 ` Tassilo Horn
2019-03-08 19:01 ` Stefan Monnier
2019-03-08 22:18 ` Stefan Monnier
2019-03-09 6:52 ` Tassilo Horn
2019-03-08 18:52 ` Stefan Monnier
2019-03-02 21:25 ` Leo Liu
2019-03-03 9:25 ` Tassilo Horn
2019-03-04 0:23 ` Leo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zsx18at.fsf@gnu.org \
--to=tsdh@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).