From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: Proposed changes to gnus-dup.el Date: Mon, 25 Mar 2019 18:13:46 +0000 Message-ID: <875zs6rfdx.fsf@tcd.ie> References: <8736nbip4l.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="115636"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Eric Abrahamsen , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 25 19:18:49 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8UBI-000Tpe-2Q for ged-emacs-devel@m.gmane.org; Mon, 25 Mar 2019 19:18:49 +0100 Original-Received: from localhost ([127.0.0.1]:46520 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8UBG-00012U-VW for ged-emacs-devel@m.gmane.org; Mon, 25 Mar 2019 14:18:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:32975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8U6c-0005Of-Cb for emacs-devel@gnu.org; Mon, 25 Mar 2019 14:13:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8U6Y-0006SH-HQ for emacs-devel@gnu.org; Mon, 25 Mar 2019 14:13:54 -0400 Original-Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]:44548) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h8U6X-0006Ry-Vj for emacs-devel@gnu.org; Mon, 25 Mar 2019 14:13:50 -0400 Original-Received: by mail-ed1-x534.google.com with SMTP id x10so8357067edh.11 for ; Mon, 25 Mar 2019 11:13:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=oGiKY5mrxNPVks71OIFiDTntHfrOy0ZVNCyrTpdlLHk=; b=fNXgvc+UpgUi4zai6g9LCgKi0LA2rxCNr8T+4YMchomzThZAEUj5wYmwKDa5imf3ms XFUGuqpHiZYGbIWDblJ8l2cuR7tcSUjnzTw6bSdl9JNJNudVy20iIj9GPeowqEMnPjYc rpruERr7jM0XRr+2qNFK3htqskjQSN+IvIIY5oNVWtSKD4r+Kms3AquYHMpA/9X6W1AY Ct+V5uoD2d+ppNCoTpXO85N8u4rJqS2cFobZbmsBxcoXubEeRFo+sB+193MEokcaJ9Ei HBw98i1GLPHoHSSPWk+ExuMeq2DhgdF5gmdKT5XIdaA9EbrF169ffwyBrCOyZoYHCF7U 5izg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=oGiKY5mrxNPVks71OIFiDTntHfrOy0ZVNCyrTpdlLHk=; b=KYYXMry0RvKahHh+YV0J8w2bTCzrcuSbZ9bJvYkYbFd2agTptgpOMWzG1IOwfIEC58 9UAycEccwg9qtzMLoodW5MqmSGG1RghAyUmZ3MzVn/zKgtQVaqJEeaYGXS5Xmxo7nXvo 1vlSOz4eEwxkOkTWq8Lnsjp0M/MzjPaa+8BRXrUg+c3TnIihsmesEG6FFD0z5/FnOsvE +URDWDZFnsgX9/UyNqkd32Czp+ahQHof6AmAMA8zeCRRsBVniz6tffz+FCG899yeKnGD 04imVakJJXVSSK1asuRkJXbz83aL/HRsXjhIZ9ABq7moVszthWwXgQc1SHaoEL+mrLU+ X1Qw== X-Gm-Message-State: APjAAAVAzkFXHuPT2CGWQqvS89Tp/ZJVLBfdxb4jgd8S51XFVKIziNsN mArwKI1dp3S3qeyQ3D5frubIig== X-Google-Smtp-Source: APXvYqzc1Uyi/9uf9WmpUBbWLMeA3j83oLfFCTcyl031ScXeRK92gLI+30PJ8bOrXxeHiSHROOZBUQ== X-Received: by 2002:a05:6402:1806:: with SMTP id g6mr15166949edy.242.1553537628593; Mon, 25 Mar 2019 11:13:48 -0700 (PDT) Original-Received: from localhost ([134.226.214.210]) by smtp.gmail.com with ESMTPSA id w9sm6098213edw.41.2019.03.25.11.13.47 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 25 Mar 2019 11:13:47 -0700 (PDT) In-Reply-To: (Lars Ingebrigtsen's message of "Mon, 25 Mar 2019 18:42:32 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::534 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234719 Archived-At: Lars Ingebrigtsen writes: > "Basil L. Contovounesios" writes: > >> + (unless (or (gnus-data-pseudo-p datum) >> + (<= (gnus-data-number datum) 0) > > I'm against using `unless' on complex logic -- many people get confused > when reading it in my experience. Fair enough. > The rest looks OK. Thanks. I will wait a few more days for people to comment and push the rest of the patch if there are no serious objections. -- Basil