From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: Predicate for true lists Date: Tue, 09 Apr 2019 18:27:09 +0100 Message-ID: <875zrnay36.fsf@tcd.ie> References: <87fu3vdjjk.fsf@tcd.ie> <87bmcqhhsf.fsf@tcd.ie> <87in6xgtpb.fsf@tcd.ie> <2af892df-26cb-60b2-4fd8-067fcb3d32e9@cs.ucla.edu> <87r2kh9uwx.fsf@tcd.ie> <83h8lcnbxb.fsf@gnu.org> <87sh4s9poo.fsf@tcd.ie> <87k1q49p0i.fsf@tcd.ie> <87efgbbq2p.fsf@tcd.ie> <87a7gz8hp2.fsf@tcd.ie> <87mukzb173.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="179835"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 09 19:27:31 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDuWw-000kgM-Ls for ged-emacs-devel@m.gmane.org; Tue, 09 Apr 2019 19:27:30 +0200 Original-Received: from localhost ([127.0.0.1]:46847 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDuWv-0000a0-Jt for ged-emacs-devel@m.gmane.org; Tue, 09 Apr 2019 13:27:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDuWi-0000Sz-BV for emacs-devel@gnu.org; Tue, 09 Apr 2019 13:27:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDuWg-0003st-Rq for emacs-devel@gnu.org; Tue, 09 Apr 2019 13:27:15 -0400 Original-Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]:33449) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hDuWg-0003rV-6S for emacs-devel@gnu.org; Tue, 09 Apr 2019 13:27:14 -0400 Original-Received: by mail-ed1-x52c.google.com with SMTP id b8so2192369edq.0 for ; Tue, 09 Apr 2019 10:27:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=M2EdALGdE228CPudfSyOp50s++d89UNtoXPPKbZMTTE=; b=QZ3Ud3jvFqz2C2euRJLH9Qe7BbRMNulgXWFrofh79WOIGcBS8IvGqT2xu1th1Dlf3h FhLdjoEypIrvOJ0xJ7Y49Bz8CvEyCy05A1lq67up8jChiumMVa/iT7X7tso3SPTCPUDL n5wIl/t3RnCHNE0zDXxx/CGQKzjpDcOac1wlu0qHbQw5gQeZQXKj7b7pp1qypVtVnY29 qWnGvtbs8VM3Do0O6/XBRSaJ1i1yPsXvr4mI3Iol39rLMAINZWEj1/qTaR+qfwuWasIp 6BxQv6teDen8LBzpFk8n6QNI8pFjF8kyvU8W9GI0qnky54xSEIUD+X8ei1pChHCe84m2 UHcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=M2EdALGdE228CPudfSyOp50s++d89UNtoXPPKbZMTTE=; b=ODSHSiNNwS/0S3BRNKpAvYdNUdpIyn5Gk2bEWbA6eenStWmnZjI7VZi2xZ42ZuFr+3 fq12KruxOzmCacNRAMZ9la7y3ibKPtbOgGghzevwZWEVUWtINX+/VrjKA1egag6j0BuY RA4tKu8///jVzz131VrA5Ejp41BmdCOtdqkUAK31z6xhXSTLv503vxlIH9y1smseXDo7 qA/Ae0psmQM8RiuuKA2jreLGyX18SgzjQwmJ/5KYndbtx5kTZALP4ZxHUVr3Q6HDB8Sw kHzXaJpfZf8siir0514HtZT8Vfe9QcGE/i5olXL1pp7zG7sCLMl0nZZTDaZMV4yRP+5o wkJg== X-Gm-Message-State: APjAAAUDz0MP205U9xy4IPZaAIaQ9iTu+Jsy7XaWn6HpV4/JCg2cUQ34 45hvvSdC7OoZNG6LgCw5g884QZkt7/UKBYOp X-Google-Smtp-Source: APXvYqxxFOc2BoYmONEo9iaPO5oHYstmf0RlUkisAsfalCokwY5/HsvXMLPSrgEFoGIKCZZSNpyHLA== X-Received: by 2002:aa7:da51:: with SMTP id w17mr23717724eds.71.1554830831766; Tue, 09 Apr 2019 10:27:11 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id t31sm10089018edb.52.2019.04.09.10.27.10 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 09 Apr 2019 10:27:10 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Tue, 9 Apr 2019 12:32:16 -0400") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::52c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235172 Archived-At: Stefan Monnier writes: >> --- a/src/fns.c >> +++ b/src/fns.c >> @@ -5326,6 +5326,12 @@ syms_of_fns (void) >> DEFSYM (Qcursor_in_echo_area, "cursor-in-echo-area"); >> DEFSYM (Qwidget_type, "widget-type"); >> >> + DEFSYM (Qpure, "pure"); >> + DEFSYM (Qside_effect_free, "side-effect-free"); >> + DEFSYM (Qproper_list_p, "proper-list-p"); >> + Fput (Qproper_list_p, Qpure, Qt); >> + Fput (Qproper_list_p, Qside_effect_free, Qt); > > I think you can set the side-effect-free property to `error-free`, which > is stronger. Okay (I think the make_fixnum in Fproper_list_p made me think it was allocating memory). > Other than that, it looks OK (tho I personally find doing it in C to > be too painful, so I prefer moving this kind of code to subr.el). I'll move it to subr.el then if no-one else objects. >> I also attach a second patch which moves the proper-list-p tests to the >> correct file following the function's rewriting in C. WDYT? > > LGTM, Thanks, -- Basil