From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Alex Gramiak <agrambot@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, Alan Third <alan@idiocy.org>,
emacs-devel@gnu.org
Subject: Re: [PATCH] Renaming non-X x_* identifiers
Date: Sat, 27 Apr 2019 02:53:34 +0100 [thread overview]
Message-ID: <875zr0z00x.fsf@tcd.ie> (raw)
In-Reply-To: <87d0lpvq6n.fsf_-_@gmail.com> (Alex Gramiak's message of "Sat, 13 Apr 2019 10:13:36 -0600")
> From 55a39c6cb4eb9a1442dd3388766f0219bf8cd825 Mon Sep 17 00:00:00 2001
> From: Alexander Gramiak <agrambot@gmail.com>
> Date: Sat, 13 Apr 2019 09:40:03 -0600
> Subject: [PATCH 3/5] Rename non-X x_* identifiers
[...]
> * src/dispextern.h (clear_under_internal_border): New RIF function
> pointer.
[...]
> diff --git a/src/xdisp.c b/src/xdisp.c
> index ae4c405b8d..11667d2735 100644
> --- a/src/xdisp.c
> +++ b/src/xdisp.c
> @@ -11592,9 +11592,8 @@ clear_garbaged_frames (void)
> else
> clear_current_matrices (f);
>
> -#if defined (HAVE_WINDOW_SYSTEM) && !defined (HAVE_NS)
> - x_clear_under_internal_border (f);
> -#endif /* HAVE_WINDOW_SYSTEM && !HAVE_NS */
> + if (FRAME_RIF (f)->clear_under_internal_border)
> + FRAME_RIF (f)->clear_under_internal_border (f);
>
> fset_redisplay (f);
> f->garbaged = false;
This causes a segfault in 'emacs -nw' and emacsclient because
FRAME_RIF (f) is NULL in tty frames such as the initial daemon frame.
Is x_clear_under_internal_border not supposed to be run in tty frames?
Thanks,
--
Basil
next prev parent reply other threads:[~2019-04-27 1:53 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 15:07 Renaming non-X x_* procedures in xdisp.c (and elsewhere) Alex
2019-03-23 15:38 ` Stefan Monnier
2019-03-23 16:10 ` Eli Zaretskii
2019-03-23 16:41 ` Paul Eggert
2019-03-23 16:59 ` Eli Zaretskii
2019-03-23 17:39 ` Alex
2019-03-23 17:54 ` Alex
2019-03-23 18:16 ` Eli Zaretskii
2019-03-23 18:55 ` Alex
2019-03-23 19:32 ` Eli Zaretskii
2019-03-24 4:14 ` Alex
2019-03-24 4:50 ` Alex
2019-03-24 5:39 ` Eli Zaretskii
2019-03-24 15:05 ` Alex
2019-03-24 16:01 ` Yuri Khan
2019-03-24 16:13 ` Eli Zaretskii
2019-03-24 17:03 ` Eli Zaretskii
2019-03-24 16:27 ` Eli Zaretskii
2019-03-24 18:30 ` Alex
2019-03-24 18:48 ` Eli Zaretskii
2019-03-25 19:21 ` Alex
2019-03-30 10:07 ` Eli Zaretskii
2019-03-30 17:26 ` Alex
2019-03-30 17:40 ` Eli Zaretskii
2019-03-30 17:59 ` Alex
2019-03-30 18:55 ` Eli Zaretskii
2019-03-30 23:27 ` Alex
2019-03-31 14:52 ` Eli Zaretskii
2019-04-11 19:07 ` Alex
2019-04-12 19:03 ` Eli Zaretskii
2019-04-12 19:50 ` Alex Gramiak
2019-04-12 20:10 ` Eli Zaretskii
2019-04-13 16:26 ` Alex Gramiak
2019-04-13 17:20 ` Eli Zaretskii
2019-04-13 16:13 ` [PATCH] Renaming non-X x_* identifiers (was: Renaming non-X x_* procedures in xdisp.c (and elsewhere)) Alex Gramiak
2019-04-13 17:17 ` Eli Zaretskii
2019-04-13 18:43 ` [PATCH] Renaming non-X x_* identifiers Alex Gramiak
2019-04-13 19:00 ` Eli Zaretskii
2019-04-14 3:35 ` Alex Gramiak
2019-04-14 14:02 ` Eli Zaretskii
2019-04-14 15:57 ` Alex Gramiak
2019-04-14 16:10 ` Eli Zaretskii
2019-04-14 17:34 ` Alex Gramiak
2019-04-15 14:51 ` Eli Zaretskii
2019-04-15 17:46 ` Alex Gramiak
2019-04-15 18:43 ` Eli Zaretskii
2019-04-16 16:24 ` Alex Gramiak
2019-04-16 16:45 ` Eli Zaretskii
2019-04-16 16:59 ` Alex Gramiak
2019-04-16 17:04 ` Eli Zaretskii
2019-04-16 17:07 ` Alex Gramiak
2019-04-16 18:09 ` Eli Zaretskii
2019-04-24 19:40 ` Alex Gramiak
2019-04-25 5:25 ` Eli Zaretskii
2019-04-25 9:56 ` Eli Zaretskii
2019-04-25 14:50 ` Alex Gramiak
2019-04-25 15:04 ` Eli Zaretskii
2019-04-26 6:52 ` Robert Pluim
2019-04-26 8:07 ` Eli Zaretskii
2019-04-26 23:12 ` Alex Gramiak
2019-04-15 22:01 ` Stefan Monnier
2019-04-16 2:29 ` Eli Zaretskii
2019-04-16 12:55 ` Stefan Monnier
2019-04-16 14:58 ` Eli Zaretskii
2019-04-14 3:47 ` Stefan Monnier
2019-04-27 1:53 ` Basil L. Contovounesios [this message]
2019-04-27 3:46 ` Alex Gramiak
2019-04-27 11:37 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zr0z00x.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=agrambot@gmail.com \
--cc=alan@idiocy.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).