From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Fri, 03 May 2019 15:34:58 +0100 Message-ID: <875zqrfvxp.fsf@tcd.ie> References: <20190407181925.w3aztx44g5drtww2@Ergus> <83pnpx8y67.fsf@gnu.org> <20190407183806.htl4pujrb2kmk4kv@Ergus> <83mul18wpv.fsf@gnu.org> <20190407200514.2p6gfucdcdsrqe47@Ergus> <83ef6d8c40.fsf@gnu.org> <20190408085102.ozcuvs323ilfid7n@Ergus> <83bm1g8s02.fsf@gnu.org> <20190412134633.g47vybtpkwxyw7dq@Ergus> <834l73mir0.fsf@gnu.org> <20190501110808.27o64tawy2gyjocr@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="9361"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 03 23:17:35 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hMfYk-0017On-Sx for ged-emacs-devel@m.gmane.org; Fri, 03 May 2019 23:17:35 +0200 Original-Received: from localhost ([127.0.0.1]:41539 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMZI0-0002cB-AX for ged-emacs-devel@m.gmane.org; Fri, 03 May 2019 10:35:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMZHO-0002bs-1M for emacs-devel@gnu.org; Fri, 03 May 2019 10:35:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMZHN-0003Sp-6X for emacs-devel@gnu.org; Fri, 03 May 2019 10:35:14 -0400 Original-Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:40635) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMZHM-0003SE-OO for emacs-devel@gnu.org; Fri, 03 May 2019 10:35:13 -0400 Original-Received: by mail-ed1-x52f.google.com with SMTP id e56so6251846ede.7 for ; Fri, 03 May 2019 07:35:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=etB7MT4D8dEG4Pxp21JC7c9h/MvxptBYGmzooimSX5k=; b=TtqS5gUY6jz8gi5Ivplw5ysW9rFHECCm+bZNRDgEqfiKh25Lpfuiq5Tkj7WsJhGUXv n28oMhJfsLdB7hVuCX9V0aizmmDw67zGXoqpmsZGw2VTRGE8mRluHc0wlGS1dTnDZULw z9Pc+A/qpHOAjAi6dQuB3fABiyvajDvOfg8Fr5hij9Wn+WDd8oTgLtLxThFKuB9m3hHF CAeIVU25hfKSYN3KrX/lB0jY3/RuBUehlIkfnSd4Thb+YAAJgTbNzSfqxHJGOSvMZ/6S wWJhsXsiNOgFUoELlkmgNz8pURef0enkihEU6D0UhogL9SdJkBnkvZA2Yf+kD5d2BXV8 dCRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=etB7MT4D8dEG4Pxp21JC7c9h/MvxptBYGmzooimSX5k=; b=WqxXrUCN6rAPrSrd9AxeHq5DW/4U5rPq2UE9Dvrv3UNj+4SVzEA+TV/S6/uzTU9JzW 1+MgcIkPFWvVJRd9kEYYr+I7fBZoSRbmWcEK9iNvsZIxnz1GyqkLDHZDNKWDsGq1Y/Sd 84fQRnakTRzSNnrb3mZeCgV7lIpxK/wkEymgMVnrwag34CUn0oTi5cwkv3p68N6ff+N9 dOdF3LBIcHNsrL56F6srB6Q5aKeslTKWRJGS3vZf91JLwsLVVAy2HJE9gOTIVsWra3aV rF47DiHc+hmfi++OygXG6m8MqgyYI/MFLpjdKeJ3n2BoT44QlR8ZyXk6aopJn2GCR0/v U0PA== X-Gm-Message-State: APjAAAV82C7x1qDUz50pjbyHvcm+iDOTFkKvKwvoTBXhE77xhOAwAFz7 MXs/uSO8cm83Z0ppJ/+GwHp0Jw== X-Google-Smtp-Source: APXvYqw7qrDl2q2U5gud2tLHyCO2YwO2S15d2YJGCntuxn65yD+y113xMx0WzROjuQAhZ1W7TayY6A== X-Received: by 2002:a50:f706:: with SMTP id g6mr8660735edn.187.1556894111156; Fri, 03 May 2019 07:35:11 -0700 (PDT) Original-Received: from localhost ([86.43.103.106]) by smtp.gmail.com with ESMTPSA id i16sm357749ejh.79.2019.05.03.07.35.03 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 03 May 2019 07:35:10 -0700 (PDT) In-Reply-To: <20190501110808.27o64tawy2gyjocr@Ergus> (Ergus's message of "Wed, 1 May 2019 13:08:08 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::52f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236124 Archived-At: Ergus writes: > branch: fill_column_indicator > commit 780f1efe27a347c7fd92bbbc0b3bc1828749d953 > Author: Jimmy Aguilar Mena > Commit: Jimmy Aguilar Mena > > display-fill-column-indicator interface corrections > --- > lisp/cus-start.el | 5 +++++ > lisp/display-fill-column-indicator.el | 13 ++++++------- > 2 files changed, 11 insertions(+), 7 deletions(-) > > diff --git a/lisp/cus-start.el b/lisp/cus-start.el > index 3f58eac..b935776 100644 > --- a/lisp/cus-start.el > +++ b/lisp/cus-start.el > @@ -649,6 +649,11 @@ since it could result in memory overflow and make Emacs crash." > :value nil)) > "26.1") > > + (display-fill-column-indicator display-fill-column-indicator > + (choice > + (const :tag "Off (nil)" :value nil) > + (const :tag "On (t)" :value t)) > + "27.1") > (display-fill-column-indicator-column display-fill-column-indicator > integer "27.1") > (display-fill-column-indicator-character display-fill-column-indicator I'm not sure custom :tags should mention nil/t. Why is :value needed/useful? Should this variable be defined as DEFVAR_BOOL for now, with :type 'boolean? Thanks, -- Basil