From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 305dbc7 2/4: Move description of value to syntax-ppss function. Date: Wed, 30 Oct 2019 16:29:44 +0100 Message-ID: <875zk6tfo7.fsf@gnus.org> References: <20191030121649.15369.13207@vcs0.savannah.gnu.org> <20191030121651.BFCF8204DF@vcs0.savannah.gnu.org> <87eeyutgwa.fsf@gnus.org> <333d1d46-ab79-5818-4367-b28ed915aff6@yandex.ru> <87a79itfzp.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="132834"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 30 16:35:21 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iPq0G-000YHv-Do for ged-emacs-devel@m.gmane.org; Wed, 30 Oct 2019 16:35:20 +0100 Original-Received: from localhost ([::1]:41666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPq0F-0005yh-4G for ged-emacs-devel@m.gmane.org; Wed, 30 Oct 2019 11:35:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44141) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPpux-0001in-MO for emacs-devel@gnu.org; Wed, 30 Oct 2019 11:29:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPpuw-0004O9-Io for emacs-devel@gnu.org; Wed, 30 Oct 2019 11:29:51 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:52790) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iPpuw-0004M2-CT for emacs-devel@gnu.org; Wed, 30 Oct 2019 11:29:50 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iPpuq-0008TE-PL; Wed, 30 Oct 2019 16:29:48 +0100 In-Reply-To: <87a79itfzp.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 30 Oct 2019 16:22:50 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241630 Archived-At: Lars Ingebrigtsen writes: > So perhaps that patch should be reverted anyway. Or have the list in > both functions. Or, even better, stop saying > > (if (nth 5 state) > (do-something-incomprehensible) > (do-something-else-incomprehensible)) > > everywhere and just add accessor functions already, so that the code > becomes marginally more readable. Because trying to make sense of it > now is just too hard, and it doesn't have to be. If we want to do this, I volunteer to start doing the rewrite -- I have some functions for this from the decoded time makeover... So what would the accessor macros be? Err... looking at the doc string, something like: ppss-depth ppss-start-innermost ppss-start-last-complete-sexp ppss-string-terminator ppss-comment-nesting ppss-after-quote-character ppss-minimum-paren-depth ppss-comment-style ppss-start-comment-or-string ppss-open-paren-positions ppss-two-character-syntax ppss-internal -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no