From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Roland Winkler <winkler@gnu.org>
Cc: "Glenn Morris" <rgm@gnu.org>, "Francesco Potortì" <pot@gnu.org>,
emacs-devel@gnu.org
Subject: Re: master 45a1653: ; Fix last change to bibtex.el
Date: Wed, 18 Nov 2020 12:30:43 +0000 [thread overview]
Message-ID: <875z6226fg.fsf@tcd.ie> (raw)
In-Reply-To: <87k0ujthyb.fsf@gnu.org> (Roland Winkler's message of "Tue, 17 Nov 2020 22:19:40 -0600")
Roland Winkler <winkler@gnu.org> writes:
> On Tue, Nov 17 2020, Glenn Morris wrote:
>>> - (function :tag "Conversion function")))
>>> -(make-variable-buffer-local 'bibtex-unify-case-convert)
>>> + (function :tag "Conversion function"))
>>> + :local t)
>>
>> After this change:
>>
>> bibtex-unify-case-convert:
>> Its value is nil
>> Original value was ‘identity’
>>
>> The "nil" value causes a test failure: https://hydra.nixos.org/build/130666989
>>
>> (Perhaps defcustom's recently added :local feature, of which this is the
>> only user, is broken.)
>
> Why local at all by default? All other BibTeX customizations by default
> apply to all BibTeX buffers.
Good point. I've now reverted it.
Don't make bibtex-unify-case-convert buffer-local
88d5b1d325 2020-11-18 11:47:54 +0000
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=88d5b1d3253728bd314de36544996aa15345bd29
Thanks,
--
Basil
next prev parent reply other threads:[~2020-11-18 12:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201116233108.21940.22514@vcs0.savannah.gnu.org>
[not found] ` <20201116233110.4E83E209DE@vcs0.savannah.gnu.org>
2020-11-18 1:42 ` master 45a1653: ; Fix last change to bibtex.el Glenn Morris
2020-11-18 4:19 ` Roland Winkler
2020-11-18 12:30 ` Basil L. Contovounesios [this message]
2020-11-18 14:13 ` Roland Winkler
2020-11-18 14:36 ` Roland Winkler
2020-11-18 16:35 ` Basil L. Contovounesios
2020-11-18 17:11 ` Roland Winkler
2020-11-18 21:31 ` Stefan Monnier
2020-11-18 21:56 ` Roland Winkler
2020-11-28 22:32 ` Roland Winkler
2020-11-19 5:23 ` Richard Stallman
2020-11-19 8:25 ` Roland Winkler
2020-11-18 11:47 ` Basil L. Contovounesios
2020-11-18 16:18 ` Basil L. Contovounesios
2020-11-24 6:31 ` Lars Ingebrigtsen
2020-11-24 15:35 ` Eli Zaretskii
2020-11-24 19:26 ` Basil L. Contovounesios
2020-11-24 19:58 ` Eli Zaretskii
2020-11-24 20:25 ` Eli Zaretskii
2020-11-24 21:01 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z6226fg.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=pot@gnu.org \
--cc=rgm@gnu.org \
--cc=winkler@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).