unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: akater <nuclearspace@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: defmacro with built-in gensym declaration and initialization
Date: Thu, 21 Jan 2021 20:50:52 +0000	[thread overview]
Message-ID: <875z3qc8ur.fsf@tcd.ie> (raw)
In-Reply-To: <875z3q6q51.fsf@gmail.com> (akater's message of "Thu, 21 Jan 2021 19:34:02 +0000")

akater <nuclearspace@gmail.com> writes:

> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> Let's just say I would sooner see native arglists gain support for
>> keyword arguments ;).
>>
>> For non-native arglists, we could always extend cl-defmacro or some
>> other definition definer.
>
> Sorry, I suspect I misunderstood.  What's a native arglist?  Doesn't
> defmacro already have native support for &optional and &rest keywords?

Yes, and that's what I mean by native arglists - the ones possessed by
built-in C objects such as subroutines, lambda expressions, compiled
code, dynamic module functions, etc. and used by built-in C functions
such as funcall.

By contrast, cl-defmacro, other CL compatibility definitions, etc. have
to parse a plain Elisp arglist for CL-specific features like &aux.

>> I was referring to the arity of the macro being defined, not that of
>> defmacro.
>
> I guess I'm confused, again.  The arity of macro being defined remains
> exactly the same.  See the --partition-by example in the original
> message.  defmacro/&gensym is a drop-in replacement; it doesn't change
> any arities.

Yes, I understood that.  Here's what I said:

> IMO, this minor convenience is insufficient motivation for
> conflating/complicating a macro's global arglist, i.e. its arity,
  ^^^^^^^^^^^^^^^^^^^^^^^
> calling convention, etc., with utilities for its local body.

The bottom line is that argument lists are for arguments, i.e. the
public contract between the caller and the callee.  Local variables are
not part of this contract, so putting them there is misguided, to put it
politely, especially if the only motivation is to save a few keystrokes.

I suspect that adding support for something like &gensym to native Elisp
arglists would amount to a very intrusive change for a very minor
convenience (and IMO very unaesthetic anti-pattern).

Adding support for something like &gensym to non-native arglists such as
those of pcase-lambda, cl-defmacro, etc. would probably be more
feasible, but that doesn't necessarily mean we should do it either ;).

>> It and its variant macroexp-let2* are relevant wherever the macro author
>> wants to avoid evaluating an argument more than once, but improvements
>> are always welcome.
>
> That's usually called “once-only” but unlike once-only, macroexp-let2
> also requires a test function which is exactly why I called it “an
> overcomplicated once-only”.

Then why not improve macroexp-let2 and/or provide once-only, like I
suggested in my first message, without the need for &gensym?

> &gensym is also relevant wherever the macro
> author wants to avoid evaluating an argument more than once, and where
> the argument needs to be evaluated unconditionally, but it's more
> concise, both in terms of token count and nesting depth.  One variation
> of defmacro/&gensym accessible in the linked repository does perform the
> same elimination of bindings as macroexp-let2, only it uses a hardcoded
> test function, namely macroexp-const-p.
>
>>> Since we're moving to
>>> natively compiled Elisp, I was thinking it's going to become less
>>> relevant in near future, and &gensym covers most use cases of once-only.
>>
>> I don't see how native compilation changes how existing and new Elisp
>> macros ought to be written.
>
> What's the purpose of TEST in macroexp-let2, then, other than to
> minimise bindings in the expansion?  (Which I presume is only relevant
> when Elisp's byte compiler is used to compile the expanded form.)

As you say, it's relevant whenever you want to minimise bindings in the
expansion.  I still don't see the relation with native compilation.

-- 
Basil



  parent reply	other threads:[~2021-01-21 20:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20  8:15 defmacro with built-in gensym declaration and initialization akater
2021-01-20 13:46 ` Basil L. Contovounesios
2021-01-20 15:09   ` Stefan Monnier
2021-01-20 16:47     ` Robin Tarsiger
2021-01-20 19:28   ` akater
2021-01-20 20:55     ` Basil L. Contovounesios
2021-01-21 19:34       ` akater
2021-01-21 20:50         ` Stefan Monnier
2021-01-21 20:50         ` Basil L. Contovounesios [this message]
2021-01-21 21:05           ` Stefan Monnier
2021-01-21 21:23             ` Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875z3qc8ur.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=emacs-devel@gnu.org \
    --cc=nuclearspace@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).