From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: goto-line-history should not be buffer local. Date: Tue, 16 Feb 2021 19:13:36 +0200 Organization: LINKOV.NET Message-ID: <875z2s3s9b.fsf@mail.linkov.net> References: <87im6ugsdq.fsf@telefonica.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31257"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Richard Copley , martin rudalics , =?iso-8859-1?Q?=D3scar?= Fuentes , Emacs Development To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 16 18:22:02 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lC430-0007zO-43 for ged-emacs-devel@m.gmane-mx.org; Tue, 16 Feb 2021 18:22:02 +0100 Original-Received: from localhost ([::1]:51954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lC42z-0005k7-54 for ged-emacs-devel@m.gmane-mx.org; Tue, 16 Feb 2021 12:22:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lC415-00046M-C6 for emacs-devel@gnu.org; Tue, 16 Feb 2021 12:20:03 -0500 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:50053) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lC413-0005ow-8V for emacs-devel@gnu.org; Tue, 16 Feb 2021 12:20:02 -0500 X-Originating-IP: 91.129.98.178 Original-Received: from mail.gandi.net (m91-129-98-178.cust.tele2.ee [91.129.98.178]) (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id B37401C0002; Tue, 16 Feb 2021 17:19:54 +0000 (UTC) In-Reply-To: (Alan Mackenzie's message of "Mon, 15 Feb 2021 21:12:59 +0000") Received-SPF: pass client-ip=217.70.183.197; envelope-from=juri@linkov.net; helo=relay5-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:264897 Archived-At: > -(defvar-local goto-line-history nil > +(defcustom goto-line-history-local nil > + "If this option is nil, `goto-line-history' is shared between all buffers. > +if it is non-nil, each buffer has its own value of this history list. > + > +Note that on changing from non-nil to nil, the former contents of > +`goto-line-history' for each buffer are discarded on use of > +`goto-line' in that buffer." > + :group 'editing > + :type 'boolean > + :safe #'booleanp > + :version "28.1") > > Anybody have any objections to this? This is not an objection, just sharing a tip that to make Isearch history buffer-local like it's in web browsers, where each web page tab uses own local search history, is possible with a small code snippet: (make-variable-buffer-local 'search-ring) (make-variable-buffer-local 'regexp-search-ring) OTOH, with using defcustom it's easier to customize this, indeed.