From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Sorting command completions by recency Date: Wed, 17 Feb 2021 19:53:55 +0200 Organization: LINKOV.NET Message-ID: <875z2qslwk.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37863"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 17 18:55:36 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCR31-0009i6-9W for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Feb 2021 18:55:35 +0100 Original-Received: from localhost ([::1]:48172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCR30-0001sR-B4 for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Feb 2021 12:55:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52420) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCR23-0000mw-Mj for emacs-devel@gnu.org; Wed, 17 Feb 2021 12:54:35 -0500 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:53391) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCR21-0006h8-GK for emacs-devel@gnu.org; Wed, 17 Feb 2021 12:54:35 -0500 X-Originating-IP: 91.129.96.116 Original-Received: from mail.gandi.net (m91-129-96-116.cust.tele2.ee [91.129.96.116]) (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 1806320009 for ; Wed, 17 Feb 2021 17:54:27 +0000 (UTC) Received-SPF: pass client-ip=217.70.183.200; envelope-from=juri@linkov.net; helo=relay7-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265029 Archived-At: --=-=-= Content-Type: text/plain The recent discussion about filtering out command completions by mode reminded the problem that while icomplete shows the most recently used commands at the top of the list for M-x, trying to see a complete list with TAB changes the order of displayed commands, i.e. in icomplete there is one sorting order by recency, but in the *Completions* buffer alphabetical sorting order. This code puts the recent commands at the top as well, but probably it needs to be opt-in: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=sort-extended-command.patch diff --git a/lisp/simple.el b/lisp/simple.el index 80bc968950..838f344ab5 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -1969,6 +1969,23 @@ read-extended-command (lambda (string pred action) (if (and suggest-key-bindings (eq action 'metadata)) '(metadata + (display-sort-function + . (lambda (commands) + (if (minibufferp) + ;; Prefer recently used completions and put the default, + ;; if it exists, on top. + (let ((hist (symbol-value minibuffer-history-variable))) + (sort commands + (lambda (c1 c2) + (cond ((equal c1 minibuffer-default) t) + ((equal c2 minibuffer-default) nil) + ((and (member c1 hist) (member c2 hist)) + (> (length (member c1 hist)) + (length (member c2 hist)))) + ((member c1 hist) t) + ((member c2 hist) nil) + (t (string-lessp c1 c2)))))) + commands))) (affixation-function . read-extended-command--affixation) (category . command)) (complete-with-action action obarray string pred))) --=-=-=--