From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 388a874 2/4: Do interactive mode tagging for man.el Date: Mon, 22 Feb 2021 23:34:21 +0100 Message-ID: <875z2jenpu.fsf@gnus.org> References: <8335xs2grn.fsf@gnu.org> <87k0r3q65y.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22997"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Feb 22 23:35:32 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lEJng-0005sJ-1S for ged-emacs-devel@m.gmane-mx.org; Mon, 22 Feb 2021 23:35:32 +0100 Original-Received: from localhost ([::1]:42208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEJnf-00085D-0H for ged-emacs-devel@m.gmane-mx.org; Mon, 22 Feb 2021 17:35:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEJmn-0007IX-LF for emacs-devel@gnu.org; Mon, 22 Feb 2021 17:34:37 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:42540) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEJmg-00037J-JJ; Mon, 22 Feb 2021 17:34:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/C4FMQziCnADo7BQKsxZIwVApWjnIj3aemYFwB2FKGs=; b=lXGN9Y0pAyO6j2lC3DhuoNWG3e Ap2wVa4xPYK/ZUYx1Z/dAvjGFUWu2fXrvGGfDrR6pP0aVgl2gUHRXOf7WAU7m97sRKhspSjVtIdwI +ii1uZQl+aFMqKp10pY0L7xj8B0ebUpOOpzSdoRHcqW3MdA0v4kdNVor231hvLuLJjHA=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lEJmZ-00017O-55; Mon, 22 Feb 2021 23:34:26 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEX+/v3OvJnt5tC3 hFsYEBFYRkT///9urv4PAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+UCFhU1Ovs/AS0AAAGwSURBVDjL rZJbkuIwDEUDs4GWTf6Ju/gf43gBaaQFQKz9b2Wu7LyY/kVVVFKcXOnq0XUfjBPRQAE/hGsPcgb+ SOk1q0+Ie7JHTHcDZygCUQiBXLiaOISvBiJRyimRT45GnuPQUlUwWCLIVJlnWoFVnDuw+4lZZN4V wXv7zscbIx7vALlDuBUAoQOwL2Wmm1dhcVuN8M01pp58Pigo3Bp4pTkZcBvoF0AEv4/f4D54KOIO XF5BSllpr2FA4NRhhPlxAJTQ1sgMT2l87iAS+pgAgk9annQYYqpAeoUpEX1uqUxRWLUkTJd1XoGN 6qcI9kg9C2TLBqNHH6+CP8o1gyd9reDWQNQrLMyq00HhLlpm/RpVd5AVDbpRkMWVYuBZ7yqOAivR dgSASiq1xomTTeTbqISxaLzw1EAka86GNZ2wDvTSAFZ6YckGRC1h2UAcUUKQSyL8Cc+tuCDVhF1h TK9z3YzugPyAL9m1s9AlFXrypV5QXQB2triCGxpzdXsdyht4+Gx2pu4cLvVKVyB1D/y361BEmDcF 6tUSIQz15QBaiC63+j9Y49PgnN4jrpf4sfgHrXiwjCQ+1DoAAAAldEVYdGRhdGU6Y3JlYXRlADIw MjEtMDItMjJUMjE6NTM6NTcrMDA6MDAXQ4vkAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTAyLTIy VDIxOjUzOjU3KzAwOjAwZh4zWAAAAABJRU5ErkJggg== X-Now-Playing: Bob Dylan's _Highway 61 Revisited_: "Desolation Row" In-Reply-To: (Stefan Kangas's message of "Sun, 21 Feb 2021 04:37:45 -0600") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265513 Archived-At: I've further tweaked my interactive tagging helper command to do grepping to give a bit of information about whether the command in question is used in other places in Emacs (like in the wo/man case) and tested it in a couple of small files. Seems to work OK, but can probably do with some tweaking to reduce false positives. (global-set-key [(hyper l)] 'my-fix-command) (defvar my-prev-mode nil) (defun my-fix-command () (interactive) (let ((mode nil) (regexp "(define-derived-mode \\([^ \t\n]+\\)\\|(defun \\([^ \t\n]+-mode\\) ") change bindings) (if (not (re-search-forward "^ *\\((interactive\\)" nil t)) (message "No more interactive in this file") (recenter nil t) (save-match-data (save-excursion (beginning-of-defun) (let ((form (read (current-buffer)))) (when (and (listp form) (eq (car form) 'defun)) (setq bindings (shell-command-to-string (format "cd %s../lisp; grep -r --include '*.el' \"define-key.*'%s\"" data-directory (cadr form))))))) (save-excursion (when (or (re-search-backward regexp nil t) (re-search-forward regexp nil t)) (setq mode (or (match-string 1) (match-string 2))))) (setq change (read-string (format "%sChange to: " (or bindings "")) (or mode my-prev-mode)))) (when (plusp (length change)) (setq mode change) (goto-char (match-beginning 1)) (let ((form (read (current-buffer)))) (goto-char (match-beginning 1)) (forward-char 1) (if (> (length form) 1) (progn (forward-sexp 2) (insert " " mode)) (forward-sexp 1) (insert " nil " mode)) (forward-sexp -1)) (setq my-prev-mode mode))))) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no