unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Leo Liu <sdl.web@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: Has eval-and-compile changed in emacs 27?
Date: Fri, 26 Feb 2021 09:21:01 +0000	[thread overview]
Message-ID: <875z2fdw1u.fsf@tcd.ie> (raw)
In-Reply-To: <m11rd3dxxk.fsf@gmail.com> (Leo Liu's message of "Fri, 26 Feb 2021 16:40:23 +0800")

Leo Liu <sdl.web@gmail.com> writes:

> On 2021-02-25 22:54 -0500, Stefan Monnier wrote:
>> No, it was new back when we added the "not known to exist at run-time",
>> i.e. a long time ago.
>
> But the erldoc.el has been compiling without warnings since 24.5 and it
> suddenly changes in 27.
>
>>> What prompted the change?
>>
>> We found it useful to try and warn the users when they did
>> (eval-when-compile (require FOO)) but FOO was also needed at run time.
>
> But it's been suggesting cl-reduce, cl-mapcan not defined at runtime
> when I explicitly have (require 'cl-lib) in the file which seems
> contradictory.

What's new in Emacs 27 is auth-source now does

  (require 'cl-lib)

instead of

  (eval-when-compile (require 'cl-lib))

lisp/auth-source.el: Depend on cl-lib unconditionally
90a7cd073b 2019-11-26 14:00:25 +0100
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=90a7cd073bfc7461e0bc824e9883499fe9026727

In turn, url-parse does

  (require 'auth-source)

and erldoc does

  (eval-when-compile (require 'url-parse))
  (require 'cl-lib)

This combination seems to confuse the byte-compiler.

-- 
Basil



  reply	other threads:[~2021-02-26  9:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 13:06 Has eval-and-compile changed in emacs 27? Leo Liu
2021-02-25 14:59 ` Eli Zaretskii
2021-02-25 15:06   ` Lars Ingebrigtsen
2021-02-25 15:23     ` Eli Zaretskii
2021-02-25 21:59       ` Leo Liu
2021-02-25 15:30     ` Basil L. Contovounesios
2021-02-25 16:18 ` Stefan Monnier
2021-02-25 16:28   ` Stefan Monnier
2021-02-25 21:55     ` Leo Liu
2021-02-25 22:29       ` Stefan Monnier
2021-02-26  2:40         ` Leo Liu
2021-02-26  3:54           ` Stefan Monnier
2021-02-26  8:40             ` Leo Liu
2021-02-26  9:21               ` Basil L. Contovounesios [this message]
2021-02-26  9:33                 ` Basil L. Contovounesios
2021-02-26 12:06                   ` Eli Zaretskii
2021-02-28  1:35                 ` Leo Liu
2021-02-28  5:04                   ` Stefan Monnier
2021-02-26 14:06               ` Stefan Monnier
2021-02-26  6:36     ` Richard Stallman
2021-02-26  7:54       ` Eli Zaretskii
2021-02-26  9:09         ` Basil L. Contovounesios
2021-02-27  0:34         ` Tomas Hlavaty
2021-02-27  7:16           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875z2fdw1u.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).