From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master fbc9c59: Make goto-line-history buffer local only when so customized Date: Fri, 26 Feb 2021 13:15:02 +0000 Message-ID: <875z2f3r8p.fsf@tcd.ie> References: <20210217212130.32410.14813@vcs0.savannah.gnu.org> <20210217212132.0B17F20DFB@vcs0.savannah.gnu.org> <87wnuv3ttp.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16761"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 26 14:16:59 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lFczK-0004DY-Cf for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Feb 2021 14:16:58 +0100 Original-Received: from localhost ([::1]:44474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lFczJ-0002LP-Bb for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Feb 2021 08:16:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFcxZ-0000cx-0S for emacs-devel@gnu.org; Fri, 26 Feb 2021 08:15:09 -0500 Original-Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:40027) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lFcxW-0005CD-R3 for emacs-devel@gnu.org; Fri, 26 Feb 2021 08:15:08 -0500 Original-Received: by mail-wr1-x429.google.com with SMTP id d11so8539996wrj.7 for ; Fri, 26 Feb 2021 05:15:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=cJ9J4Ugpu5p7Nbgx+8aE1Yhx1HgBAINRcCdWSlu8qD4=; b=GcoXgLIyZ87d3Gx9VE/CcTEUQadTr2oRy9WkUTZIZs1bQG2WrFy5tB+r5jFsaOMWlo HoymrlKkQRmY4VCRzDJCw6DaQsXMEb/rsM0B++eZwamTpP5OY2+dDE8THsSxgv1vIbKs Yb/Nn48BqIaXShbVu5DCbmhZxTqW9mhWHr28TD3+k1WeuF4XIzqTZ/SsfxbRZja+l545 kPrr7dLRlBtdAqHSJygfbxBYdPTBp/Vj4QnDa9E+TUUXlUWO95J7zjUpMgeh/DDORnQ/ 3OHAj2nenCjZPF2e0dA5vS66hns1QTSmiIXhbFaBgsiodYM/wzusZMUV+HGXsdIicSDK +baA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=cJ9J4Ugpu5p7Nbgx+8aE1Yhx1HgBAINRcCdWSlu8qD4=; b=aDysx7WUIpEh5XJg71KNSbztvRe4DSK4pLaWg8qr/EUhKsbAX6GFrJd6rHm027774y wUY4oVIo0D2jdd9B2LHmD0TjxRBKH3aOi1VHgalaEGTVPEjjNMb8mDtmaIUbTn7ihjeH hbUWWPUQ2Gr58ZSXEbUruBHdazhMDjbKwXiEAzknu5L45nSNJbfngzZxwIwi3ahnR2es sQ1S0emi/8/TPFGUVSEsUGbCLnUvK8uL1kUfwFzaXoFW59tOWDgtABElC9D5nDswJPrZ OQk0JLxSPBjmVDblKAS+x2LALyjFxH7NIynIT5Axt/O/bsFVMRoE2jGGP87CQA0rwnWJ lgRQ== X-Gm-Message-State: AOAM533bJJyEiOqT6hyXbfakzXtDYpToDpwsLW4b3uUXiVq5JNHOOX1o BkrTZwiAWssyLXwSKFnlKW/dgg== X-Google-Smtp-Source: ABdhPJybBavfXlfzKBcQuO5LcWg/uVBrd/uOkI8UcsY6d5CQE5qSbwPC/+Cz+/hG3IeSu8nEbYPpSA== X-Received: by 2002:adf:f292:: with SMTP id k18mr3214364wro.335.1614345304364; Fri, 26 Feb 2021 05:15:04 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:6d2d:c2fa:f3fa:cabd]) by smtp.gmail.com with ESMTPSA id g63sm12369544wma.40.2021.02.26.05.15.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Feb 2021 05:15:03 -0800 (PST) In-Reply-To: (Alan Mackenzie's message of "Fri, 26 Feb 2021 13:01:46 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=contovob@tcd.ie; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265681 Archived-At: Alan Mackenzie writes: >> > ++++ >> > +** The history list for the 'goto-line' command is now a single list >> > +for all buffers by default. You can configure a separate list for >> > +each buffer by customizing the user option 'goto-line-history-local'. > >> I think this contradicts a preceding entry: > >> ** Input history for 'goto-line' is now local to every buffer. >> Each buffer will keep a separate history of line numbers used with >> 'goto-line'. This should help making faster the process of finding >> line numbers that were previously jumped to. > > Well, I think "contradict" is not quite the right word. Whether the list > is buffer local or not is now customisable, which it wasn't before. The > default is somewhat arbitrary, as it always is in these things, with some > people proclaiming a particular setting "obviously" should be the > default, others saying the opposite is "obvious". That the list, before > that previous patch, wasn't buffer local points to the current default. > > Or, have I misunderstood what you're saying? I think so. My point is that the older entry says goto-line has buffer-local history by default, whereas the newer entry says goto-line does not have buffer-local history by default. The older entry came with the following change: Make goto-line keep a separate input history per buffer 7c5d6a2afc 2019-12-24 17:40:15 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D7c5d6a2afc6c23a7ff= f8456f506ee2aa2d37a3b9 The newer entry came with the following change: Make goto-line-history buffer local only when so customized fbc9c59b9e 2021-02-17 21:15:51 +0000 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3Dfbc9c59b9eb02d49f4= 26341ee32334784d224ce4 The latter change reverts some parts of the former, and makes the behaviour customisable, but the older NEWS entry was not updated to reflect this. I was hoping you would merge the two NEWS entries or simply delete the older one, since it no longer accurately represents the default, and is duplicated by the newer entry. This part of (info "(elisp) Minibuffer History") also needs updating: -- Variable: goto-line-history A history list for arguments to =E2=80=98goto-line=E2=80=99. This var= iable is buffer local. Thanks, --=20 Basil