From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Semyonov via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Wed, 26 May 2021 22:32:38 +0300 Message-ID: <875yz5gujt.fsf@dsemy.com> References: Reply-To: Daniel Semyonov Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34023"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 26 22:20:19 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lm00n-0008Yw-Pa for ged-emacs-devel@m.gmane-mx.org; Wed, 26 May 2021 22:20:17 +0200 Original-Received: from localhost ([::1]:43688 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lm00l-0005cp-UM for ged-emacs-devel@m.gmane-mx.org; Wed, 26 May 2021 16:20:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llzGw-0007N5-9k for emacs-devel@gnu.org; Wed, 26 May 2021 15:32:55 -0400 Original-Received: from dsemy.com ([46.23.89.208]:45345) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llzGq-0001UQ-K4 for emacs-devel@gnu.org; Wed, 26 May 2021 15:32:54 -0400 Original-Received: from coldharbour (bzq-79-176-207-31.red.bezeqint.net [79.176.207.31]) by dsemy.com (OpenSMTPD) with ESMTPSA id 3e7db91e (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 26 May 2021 22:32:41 +0300 (IDT) In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Wed, 26 May 2021 19:12:56 +0100) Received-SPF: pass client-ip=46.23.89.208; envelope-from=daniel@dsemy.com; helo=dsemy.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 26 May 2021 16:14:38 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269927 Archived-At: >>>>> Jo=C3=A3o T=C3=A1vora writes: > Found it, it was in > https://github.com/joaotavora/eglot/issues/577, and the author, > Daniel Semyonov, is using `completing-read` directly. IOW it's not > specific to icomplete at all. Here is his code. > In that issue he states that Eglot's completion table is > problematic, and he's probably right, but the general idea of > making a completion-in-region-function from completing-read is > very interesting. It would in principle mean that every > completing-read frontend could also be used in many other places. Not to derail the thread, but I do not recommend attempting to use that function; I wrote it when I had a far worse understanding of the completion system (and by pulling bits from various other functions I've found online and in Emacs). A far more robust implementation of the same idea can be found in Daniel Mendler's Consult package (although last I tested it also had issues with Eglot). Regards, Daniel