From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 4a1e97b: New user option for Git log switches Date: Wed, 09 Jun 2021 13:14:48 +0200 Message-ID: <875yyn2st3.fsf@gmx.de> References: <20210608233619.8439.15341@vcs0.savannah.gnu.org> <20210608233620.E895F209C6@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13732"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Utkarsh Singh To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 09 13:16:13 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqwBx-0003SG-H8 for ged-emacs-devel@m.gmane-mx.org; Wed, 09 Jun 2021 13:16:13 +0200 Original-Received: from localhost ([::1]:43600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqwBw-0007Uc-DJ for ged-emacs-devel@m.gmane-mx.org; Wed, 09 Jun 2021 07:16:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqwAf-0006li-JJ for emacs-devel@gnu.org; Wed, 09 Jun 2021 07:14:53 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:43545) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqwAd-0000u5-Ps for emacs-devel@gnu.org; Wed, 09 Jun 2021 07:14:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1623237289; bh=sOtqrS17BaVyAsHe0wk33KC3V9xgri+ebJ0crRI2Df4=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=XSt+z214UWypfOufb3qbcVfKorewjeAEIrEGDMBpHX9mjRmO3PUJ5fRqy1eXNGBoT MjwEb4U7ToEf/yV8kk50m/v0nVy8POnWsHdMUjR4BUHVaX1zzRLH63eSWnEIx47VdQ ClfloIGUxN1387d3wKzDGj7ncAu9/REDrZ2mKZAY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([79.140.119.150]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MEm2D-1m79Ry02wd-00GG0i; Wed, 09 Jun 2021 13:14:49 +0200 In-Reply-To: <20210608233620.E895F209C6@vcs0.savannah.gnu.org> (Dmitry Gutov's message of "Tue, 8 Jun 2021 19:36:20 -0400 (EDT)") X-Provags-ID: V03:K1:khYzWSDBdJWiVACDIWww7K0VuDhSqdJFlIXoVBONFObmNHAGAMY DGwRTrd613VRFAYgGTN9U587X1sGxajgI1Sc2JeWjCYbQqF7zaqImfhRN6klq0+qfAF3x3d Iqde8sZXpGZ9XYcVK4Iyub6kaBGyr+jGP18mtXp0qcbJ2B9pmWmhUHNO3lMEKdla18zXeea koGmuYvvED3tEY900ucWg== X-UI-Out-Filterresults: notjunk:1;V03:K0:t645o05FvA4=:YTBUIADw9/XpxsAV7HRSP5 SJ5Grsd6xTLxPv5zHlbyID+ntr0X0+SJAP6RX4oZIGM0pXN/SOidLUVdVSBdKgv5KU51HlbYu TnbTrsbUG7KsqzaBKM58ykfB5XSYoujBYnRoQftxe1ES7T3AiTF5q0N6gIHHaMykmHRwK5zSY 2l1FnHAWiFwzr99beMnifHvQ9fubcI7+Aoj3PFB/g+2/ndPEqzkeoRramCnKSEtE/aexqHDBh Pw9CvO9bFClKrxsRO/PB20jr5paL/aMZBpOsF5v6DcwitOpUKiFj7b4PvH8+LFA5h7JIDk/q4 2XQafDg90qDP2v1rhQ7IL2r0dKzWnfDottfzoAQAHOJFG/cDkrS1mFCeAtMwDe1HL1TkGxaVN YjY84h5FGQXxL+xpUhB69IinxRfycbBG1ixp+dcdp41pcoq98YZcLHm2LlESHx0am3Vm7+tFO rfq3tHE38RuC/2uNbAKyuRj/LnouHlqpGfjtGP+/ivST7mqHp3SdTICZAD6gZDbnwab+xgpeK dyLGz6fwbTfNaR6bpAeIZy5FAjMK0r6VjLV6e3ECaIWXX4hWcoTd/e9zIghAxq/gGrIdMQ9/H 3uSwkNLNXfFOdlZ65JfDPNo99yVidcEPJq8NuVWCBFVXliA1zt92AK4Yn0KgdlxkO6/TvZ5FC H9XcumZtdwhQxAx2sJtd1PRwKnCJfTZR70OllD1BuhdRVt8ye6IlU/U8esrDjact7cuNcrvwE IU4GZi/cviKZD4ZgBRatb2wpq4eDJxqFM+sfgw4kidBgKs6+ZlC5hBPST0r3Lm5qhK9OxGdc Received-SPF: pass client-ip=212.227.15.19; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270594 Archived-At: dgutov@yandex.ru (Dmitry Gutov) writes: Hi, sorry for being late. > +(defcustom vc-git-log-switches t > + "String or list of strings specifying switches for Git log under VC." > + :type '(choice (const :tag "None" t) > + (string :tag "Argument String") > + (repeat :tag "Argument List" :value ("") string)) > + :version "28.1") Is there a reason to use the t value for "None"? All other log switches (vc-bzr-log-switches, vc-hg-log-switches, vc-src-log-switches) use nil for this purpose, and it sounds also more natural to me as being an empty list of strings. Best regards, Michael.