From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [WIP PATCH] Adding keys to keymaps in alphabetical order (for use with `mode-line-mode-menu') Date: Wed, 23 Jun 2021 16:10:14 +0200 Message-ID: <875yy4llix.fsf@gnus.org> References: <87tulu11f1.fsf@gnus.org> <87bl7ztn4p.fsf@gnus.org> <44969496-4f6c-e299-9fee-7bad01c17815@gmail.com> <87a6ngn31s.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14533"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Jim Porter , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 23 16:11:03 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lw3ao-0003bS-Th for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Jun 2021 16:11:02 +0200 Original-Received: from localhost ([::1]:51980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lw3an-00045s-TH for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Jun 2021 10:11:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lw3aA-0003QJ-MC for emacs-devel@gnu.org; Wed, 23 Jun 2021 10:10:22 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:38942) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lw3a8-000865-U4 for emacs-devel@gnu.org; Wed, 23 Jun 2021 10:10:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=K3wJRgwZdcfCZbXwyXXfAYWZPmA5zEuVkLMIKmQd23c=; b=gIA9wcTKKemPKr6lfNWzezYe4P X+EeVi527texMWr6Cy6KZtQJ3FTw+wX8Lxonu8gBPbkg6Rkb1nitNQiW9ROB7ykmNPweN+K6VweW2 lA9nL119MOeby3hGksk2uQSpln7chets84OX4EACsViV2BLFurhwNbEWelayXe0mqf2A=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lw3a3-0005cC-Fq; Wed, 23 Jun 2021 16:10:17 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEXHvq9gW1ZSJywb FhWPV1v///9jtUDFAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+UGFww4FbuLG2MAAAG0SURBVDjLdZSB jesgDIadewyAORbAdICL6QA2x/4znQkkoVKepbYSX39s/xgA/hsBn8IDFCpcKDNxJotceuQfAKZM WV+VXlWkEr0k5FJ/usL+mV+RqEEjqm8lOhRdSeQrvQEUG+Gx2QSccNNeiQKGsABDfha55VVRmOJZ /vapILLiQ+otrIpjuR0Ch9RX3h3kAWaEfAO2jqM2ca21IZhgR7lyQyt0grKrtAu4kq/ku/pNnkF0 zwpEuUHmFdzJR8cD8NndYcknwEewhxSdZbGPE1284jAtiVEN5BVQoETJJibq0fkE5lWwLzTbIxKt ihAoh05gQ7y9MrMLJUjfHMBFq4snaBhYvbRvqgDe3QpQ3UUQopoDsl3AMsHuAeHXO4aegxfQu/7n NSneVZ3A2bzp19L57rxtLzahLtXf1SuMDVUQ1QZ0jMnpbpQgiuJw65Z9WDLCRLSeR7dwDuiqsIHr a7FFRW1N9eMEA1q141D046AmmEWtyZPd7Ova2h2Uqyq/4X2fH8Bdbr8Fdr9brP0n10w8H4BSuS9Z sWefXEfy/lq88ljrrwEfWw0rknkRrgzjJJ7jD7BVjujBIt4hAAAAJXRFWHRkYXRlOmNyZWF0ZQAy MDIxLTA2LTIzVDEyOjU2OjIxKzAwOjAwHtSp5QAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wNi0y M1QxMjo1NjoyMSswMDowMG+JEVkAAAAASUVORK5CYII= X-Now-Playing: The Clash's _Sandinista!_: "The Call Up" In-Reply-To: (Stefan Monnier's message of "Wed, 23 Jun 2021 09:58:19 -0400") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270990 Archived-At: Stefan Monnier writes: > But the above code will mess things up when applied to a keymap that has > a parent keymap. > > It will also fail to do its job on menu keymaps which use a vector > rather or on composed keymaps (which can be > created "implicitly", e.g. when looking up `menu-bar` in a keymap which > has a `menu-bar` binding and which additionally inherits from a keymap > that also has a `menu-bar` binding). Ah, right. I'll revert the commit then (for now). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no