From: Tassilo Horn <tsdh@gnu.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: emacs-devel@gnu.org, Daniel Nagy <danielnagy@posteo.de>
Subject: Re: Definition reasoning of revert-buffer-function, should it be defvar-local?
Date: Tue, 10 Aug 2021 16:46:47 +0200 [thread overview]
Message-ID: <875ywdmk00.fsf@gnu.org> (raw)
In-Reply-To: <87czql8j2l.fsf@igel.home>
Andreas Schwab <schwab@linux-m68k.org> writes:
>> I want to understand the reasoning behind the definition and the
>> intention of the variable `revert-buffer-function`.
>>
>> In `files.el` I see the following definition:
>>
>>> (put 'revert-buffer-function 'permanent-local t)
>>> (defvar revert-buffer-function #'revert-buffer--default)
>>
>> The first line suggests to me, that the intention of the variable is that it is
>> supposed to be buffer-local, but `defvar-local` was not used.
>
> When these lines were written, defvar-local didn't exist.
Hehe, sure. But why hasn't `make-variable-buffer-local' been used? I
agree with Daniel that nobody should ever alter the global value of
`revert-buffer-function' but it is easy to do that accidentally.
Bye,
Tassilo
prev parent reply other threads:[~2021-08-10 14:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 13:51 Definition reasoning of revert-buffer-function, should it be defvar-local? Daniel Nagy
2021-08-10 14:34 ` Andreas Schwab
2021-08-10 14:46 ` Tassilo Horn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ywdmk00.fsf@gnu.org \
--to=tsdh@gnu.org \
--cc=danielnagy@posteo.de \
--cc=emacs-devel@gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).