From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.erc.general,gmane.emacs.devel Subject: Re: [ELPA] New package: ERC Date: Sun, 19 Sep 2021 16:38:31 +0200 Message-ID: <875yuwpr4o.fsf@gnus.org> References: <87tuih3jfq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29509"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-erc@gnu.org, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Amin Bandali Original-X-From: emacs-erc-bounces+sf-erc-help=m.gmane-mx.org@gnu.org Sun Sep 19 16:38:46 2021 Return-path: Envelope-to: sf-erc-help@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRxxt-0007W8-Ho for sf-erc-help@m.gmane-mx.org; Sun, 19 Sep 2021 16:38:45 +0200 Original-Received: from localhost ([::1]:37770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRxxs-0002hF-21 for sf-erc-help@m.gmane-mx.org; Sun, 19 Sep 2021 10:38:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRxxp-0002gV-Ff; Sun, 19 Sep 2021 10:38:41 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:59544) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRxxn-0003PD-UZ; Sun, 19 Sep 2021 10:38:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=taEch4EUTrGnl6YRdz5LWfT00Oed6JJbcq+hvHc7Gpo=; b=gSiDrrf1i9aRygN9u1Oma78c55 OrO4ya6YqW6HbeHKA1ypnYiQuUm0IsZprLg6QUrlAhSyXMm5J44jyi2fY9L4z4I9tClvFCQ0sOuLY /+Ge75ZWl+qyp5MiYt3zW4vUNb6usSDCIOHWark7A8FYmHGAVOKE7pkNB1eEeErCxd8w=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRxxh-0007h9-6m; Sun, 19 Sep 2021 16:38:36 +0200 In-Reply-To: <87tuih3jfq.fsf@gnu.org> (Amin Bandali's message of "Sat, 18 Sep 2021 13:03:21 -0400") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-erc@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: General discussion about ERC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-erc-bounces+sf-erc-help=m.gmane-mx.org@gnu.org Original-Sender: "emacs-erc" Xref: news.gmane.io gmane.emacs.erc.general:1593 gmane.emacs.devel:275054 Archived-At: Amin Bandali writes: > 1. Making the iso8601 dependency optional; or even better, adding it > to GNU ELPA and adapting it to only use the new functions like > `string-replace' on newer Emacsen. > > What do you think about this, Lars? I don't think there's much point in using `string-replace' at all in packages that are meant to be used in older Emacs versions -- they can be trivially rewritten to use `replace-regexp-in-string' always. But I'm not sure whether it makes much sense to put a bunch of the built-in Emacs libraries in ELPA -- perhaps it does make sense for iso8601.el (even if there's been some internal time changes for time representation of sub-second times), but for instance: > 2. Adding browse-url to GNU ELPA, since erc-button uses its > `browse-url-button-regexp', which was only added in Emacs 27. > We could probably adjust erc-button to fall back onto Gnus's > `gnus-button-url-regexp' on older Emacsen, but I think I'd > rather not do that. It's just a slippery slope, as you've found out with erc. Putting stuff into ELPA adds a real added maintenance cost, because you can't use modern idioms and better constructs like: > 3. Not using `with-suppressed-warnings' (added in Emacs 27) on older > Emacsen and perhaps fall back on `with-no-warnings' for the single > use of that macro instead. Using `with-no-warnings' is usually a disservice, because it pastes over other potential errors other than the one you meant to inhibit. So I'm sceptical about all of this -- is the added utility of having these libraries in ELPA for users so big that we want to take on the added maintenance burden? I'm doubtful. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no