From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuri D'Elia Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Improve interaction between mouse-drag-region and scroll-margin Date: Sat, 25 Sep 2021 18:31:40 +0200 Message-ID: <875yuozker.fsf@wavexx.thregr.org> References: <20210925160922.114811-1-wavexx@thregr.org> <83zgs0pr3i.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12977"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: emacs-devel@gnu.org Cancel-Lock: sha1:7UBy2Zm69RKuLha71QOoKTiScY4= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 25 18:32:37 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mUAbM-0003EP-Bn for ged-emacs-devel@m.gmane-mx.org; Sat, 25 Sep 2021 18:32:36 +0200 Original-Received: from localhost ([::1]:58476 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUAbL-00089t-BR for ged-emacs-devel@m.gmane-mx.org; Sat, 25 Sep 2021 12:32:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUAad-00077P-5e for emacs-devel@gnu.org; Sat, 25 Sep 2021 12:31:51 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:50378) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUAab-0004Yd-J1 for emacs-devel@gnu.org; Sat, 25 Sep 2021 12:31:50 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mUAaY-0002EB-2D for emacs-devel@gnu.org; Sat, 25 Sep 2021 18:31:46 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275462 Archived-At: On Sat, Sep 25 2021, Eli Zaretskii wrote: >> auto-hscroll-mode in mouse-drag-region and do not re-enable them until >> dragging is over, making selections work as expected when inside the >> margins. > > If you disable auto-hscroll-mode, why do you also need to zero out > hscroll-margin? It doesn't, it just disables auto-hscroll-mode. Maybe I should reword the commit. >> + ;; Suppress automatic scrolling near the edges while tracking >> + ;; movement, as it interferes with the natural dragging behavior >> + ;; (point will unexpectedly be moved beneath the pointer, making >> + ;; selections in auto-scrolling margins impossible). >> + (setq auto-hscroll-mode nil) >> + (setq scroll-margin 0) > > Shouldn't this be in unwind-protect? I guess, yes. There's probably more side-effect that would be need to be taken-care of inside that big let* (looking at that mouse-set-point...). > And I think this also warrants a NEWS entry. Ok