Re: [PATCH] New tab-bar-detach-tab command

[Adam Porter <adam@alphapapa.net>]

[-- Attachment #1: Type: text/plain, Size: 1534 bytes --]

Hi Juri,

Juri Linkov <juri@linkov.net> writes:

> Thanks.  The command 'tab-bar-move-tab-to-frame' was intended
> to do exactly this.  If it doesn't, then it would be better
> to fix it, for example, by improving its 'interactive' spec, etc.
> Then you can add an alias 'tab-bar-detach-tab' to it.

Looking at that command, I'm not sure how to change its interactive spec
to move a tab to a new frame without changing the command's documented
behavior.  But using it to do the work of moving a tab to a new frame
created by another command is straightforward and easy for me to
understand.  :)

I've attached a new patch for your consideration.  It seems to work
correctly (correcting the issue Matt noted), and it also adds the new
command to the tab bar context menu.  If you'd still prefer to change
'tab-bar-move-tab-to-frame' to accomodate this functionality, I'm not
sure what you have in mind.

>> It might be worth binding it to something like "C-x t D" as well,
>> assuming the command is worth merging.  :)
>
> Currently I'm developing a command that will detach a window
> to a new tab, i.e. it will delete the selected window
> from the current tab after moving it to the new tab.
> And I'd like to add a keybinding to it with the same mnemonics "D" :-)

Hm, what if the new window-detaching command were on "C-x t d", and the
new tab-detaching command were on "C-x t D"?  Of course, "C-x t d" is
currently bound to 'dired-other-tab', but it seems like that should be
covered by 'other-tab-prefix', i.e. "C-x t t C-x d".

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: New patch --]
[-- Type: text/x-diff, Size: 1831 bytes --]

From 9deb82def15669d7cd520ec33caf345af0e4ce79 Mon Sep 17 00:00:00 2001
From: Adam Porter <adam@alphapapa.net>
Date: Tue, 28 Sep 2021 14:03:01 -0500
Subject: [PATCH] * lisp/tab-bar.el: (tab-bar-detach-tab) New command

(tab-bar-detach-tab): New command.
(tab-bar-mouse-context-menu): Add menu entry.

With thanks to Matt Beshara <m@mfa.pw> for his feedback.
---
 lisp/tab-bar.el | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el
index abf0e81..44b89c8 100644
--- a/lisp/tab-bar.el
+++ b/lisp/tab-bar.el
@@ -307,6 +307,11 @@ tab-bar-mouse-context-menu
                       :help "Undo closing the tab"))))
 
      (t
+      (define-key-after menu [detach-tab]
+        `(menu-item "Detach" (lambda () (interactive)
+                               (tab-bar-detach-tab
+                                ,tab-number))
+                    :help "Detach the tab to new frame"))
       (define-key-after menu [duplicate-tab]
         `(menu-item "Duplicate" (lambda () (interactive)
                                   (tab-bar-duplicate-tab
@@ -1201,6 +1206,17 @@ tab-bar-move-tab-to-frame
       (tab-bar-tabs-set to-tabs to-frame)
       (force-mode-line-update t))))
 
+(defun tab-bar-detach-tab (&optional from-number)
+  "Detach tab number FROM-NUMBER to a new frame.
+Interactively or without argument, detach current tab."
+  (interactive (list (tab-bar--current-tab-index)))
+  (let* ((tab (nth (or from-number 1) (funcall tab-bar-tabs-function)))
+         (tab-name (alist-get 'name tab))
+         (new-frame (make-frame `((name . ,tab-name)))))
+    (tab-bar-move-tab-to-frame nil nil from-number new-frame nil)
+    (with-selected-frame new-frame
+      (tab-bar-close-tab))))
+
 \f
 (defcustom tab-bar-new-tab-to 'right
   "Defines where to create a new tab.
-- 
2.7.4