From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Suggestion for improving ergonomics of repeat-maps: define-repeat-map Date: Mon, 04 Oct 2021 21:18:35 +0300 Organization: LINKOV.NET Message-ID: <875yuc7hzo.fsf@mail.linkov.net> References: <874katproz.fsf@mail.linkov.net> <87h7etsjxx.fsf@gnus.org> <446cdb8d-7075-4942-bfbe-74653dd32a03@www.fastmail.com> <875yudqjwi.fsf@gnus.org> <878rz9gnxw.fsf@alphapapa.net> <87fsthnmpv.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31696"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Adam Porter , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 04 20:41:49 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXSuK-00083z-Kf for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Oct 2021 20:41:48 +0200 Original-Received: from localhost ([::1]:55694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXSuI-00081y-QO for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Oct 2021 14:41:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXSsl-0006AD-Il for emacs-devel@gnu.org; Mon, 04 Oct 2021 14:40:11 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:38981) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXSsi-00070a-83 for emacs-devel@gnu.org; Mon, 04 Oct 2021 14:40:11 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id ACD34E0008; Mon, 4 Oct 2021 18:40:03 +0000 (UTC) In-Reply-To: <87fsthnmpv.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 04 Oct 2021 11:49:48 +0200") Received-SPF: pass client-ip=217.70.183.196; envelope-from=juri@linkov.net; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276243 Archived-At: > But I guess it's a bit confusing how the syntaxes are similar but > different? I went back and forth a number of time on the syntax -- > define-keymap is a function, so it can't do the function-line macro > syntax that defvar-keymap can (which is better). But having the first > argument of define-keymap be a list (which would be preferable in most > ways) just looked awkward. > > (define-keymap (list :full t) > ...) > > But I'm open to changing it if it's too confusing the way it is now. But why not to unify them in another direction, i.e. not to use a list for options in defvar-keymap. Then both syntaxes would be the same: (define-keymap :full t "g" #'eww-reload) (defvar-keymap eww-textarea-map :full t "g" #'eww-reload) instead of (defvar-keymap eww-textarea-map (:full t) "g" #'eww-reload)