From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: DPS font backend uses the wrong font Date: Sun, 17 Oct 2021 21:20:43 +0800 Message-ID: <875ytvbxec.fsf@yahoo.com> References: <875ytvbxec.fsf.ref@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6133"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 17 15:22:14 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mc67B-0001ME-2M for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Oct 2021 15:22:13 +0200 Original-Received: from localhost ([::1]:41758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mc679-00055t-6Q for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Oct 2021 09:22:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mc65x-0004Ow-PU for emacs-devel@gnu.org; Sun, 17 Oct 2021 09:20:57 -0400 Original-Received: from sonic312-23.consmr.mail.ne1.yahoo.com ([66.163.191.204]:39077) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mc65u-0004xt-0q for emacs-devel@gnu.org; Sun, 17 Oct 2021 09:20:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1634476852; bh=5a4Z7t3LXBGkFh+g9umTEoASfhYO0zM5EwTF6cw0yLk=; h=From:To:Subject:Date:References:From:Subject:Reply-To; b=fQXzE1ydHUdIfUefYQmmPohfAoko/DJfPlZpQPzZO4NTpXmeF2k4ZmaeGBxcUDuh0Dve5rmkyj7LTUGiJ8ig7Z1OQ4QzyYZe6jOMO7Eik33NRPh5q3d3UwMDKt+LZgRBIcUPW3tY9vJunFfBQYa0i1i9roOju03EvXj95iRuB6Qf1fb6+raB+puKmJwPRKihTbbEJMSDwbHmR0G1q8ScsqB/br8mKHYCxQA6/yF0ltuJuWkPuSaEL84TevD33OPWxUYf2DWti1qUYb/myudN58PXMOxqMRGaJMqn9nfskAblKfeQJowZFk6HMif5Fp2dV/trcbZ/i1xt2yTaoOvdHA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1634476852; bh=K0R9mmv0jhK1SqmVEHDsGCnEaPl+O0xbN9QAfLYa5i8=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=dbGraACdGXjX1jDR0WcJ2EMfE2Zy3hVfL2lF8G499SQkVn3uAnHWf9GWV5p02gAF0xSC5saKtycsGuKZeZ8J0hpsX37JQpWypoLb1LI/QSHJc1rQDkOZ6pV3Cku+R94+iqnaO5LSXiVb2LVGeJrEM/WQUqTDALLLq/2wqKRUdKoeRyN+aG7HDo41L7QERjmAWe8fJSVagMATxUpvfGXnjwcELZdnvsKIcq39Xj5qNiOHOJpNVeMAOLAjtK/Fvrd/qE1UteOEO5aHG0hP2aEUKo2GKys54gBXN9rjiIMSDaMrGeKckakRK2fJybPl4L6zHXibYyRFkaQ6380WwPzNeQ== X-YMail-OSG: YhckMuMVM1lgSy.G12T5bpZdz0mmAaCL_niKOTvvBzB7KRG6gybO7RWGXXV6jQv E4KOOTlw0xNjTFRXopvQAkEIyVDKbFmUvAeBuMX3IAYsxLdypM4bt9raryqsMCPSqJ6ZnYuPW58b 4Wdw1SSSEYW4XEubK48BbetIlWy6ZS6qjH5XpF8jCTNFN_WudS533TPnmy009U9TRouRgIfdRSzP mt8nLbC21p0qOztAs26vBRqOiHSh15TcRSTQ7bcBDpsXvINocx1By4dlTzcuWPYev7vb6pPr2GdA cuBh7k_9s6gDRiCQ77xOF9h5IwC4qiRuICmLgYB8dD6JXoAJvGbjPzIlqoMnTLFBiJIQRNvUgC5q cr5vv2VN7Upn4y6e5jid8wXpiI7rQjIc8PAJOoeFwhafVRW0bRcS1kajSw0v1uCsAcotO2mrgN58 0OSroAALJUQqqwUgTm.fG2yRyfD8BpZ7iskYy183uotLci1Pdzn418dfWyPxGu6ALtbtDc8xaJVP FkypOOnr7Ef7Tb4KV9f4E3UIbUVE86MpLqgk99aKXn0A.CVnfHtqNcU51q2A75mw7mMh9jN.K3WP 3n794frI.A0nq4eBCVlrO1XoFYyeF1.Qw_m0P9PDM3eT746wOSVSTNNfKpwnXSOLIcMHQ4_INz4F U4zAzYu8.Wc_M7htPi6P_33MW8oaMl4VPBJCNK1U0WX93BChIs4Yk9K.ExF6YAGa7nide2uJSjm3 Q4OyJBmCYjPQfYxo3FKMuYYZxIRuqp_IPh__r0poxVb6V8XdnxtQvVG4mjP3mlc_OedZW5Smv8V_ V4gK1MyYPUpbeA3oJGz_YrfrldDqrmrlhvR3kzWlew X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Sun, 17 Oct 2021 13:20:52 +0000 Original-Received: by kubenode514.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 1f1c41740444d56030558697f26e213f; Sun, 17 Oct 2021 13:20:46 +0000 (UTC) X-Mailer: WebService/1.1.19116 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.191.204; envelope-from=luangruo@yahoo.com; helo=sonic312-23.consmr.mail.ne1.yahoo.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) BAYES_40=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277214 Archived-At: As of 2028df78, font backends are required to use s->font instead of s->face->font, even in the NS port, because s->face is now set to mouse face by redisplay independently of terminal specific code. Every font backend except for nsfont already does that, so it would make sense to change nsfont to do it correctly as well. But is there something I'm missing here? IOW, I'm suggesting to change the following snippet of nsfont_draw: font = (struct nsfont_info *)s->face->font; if (font == NULL) font = (struct nsfont_info *)FRAME_FONT (s->f); to font = (struct nsfont_info *)s->font; if (font == NULL) font = (struct nsfont_info *)FRAME_FONT (s->f); Thanks.