unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: emacs-devel@gnu.org
Subject: DPS font backend uses the wrong font
Date: Sun, 17 Oct 2021 21:20:43 +0800	[thread overview]
Message-ID: <875ytvbxec.fsf@yahoo.com> (raw)
In-Reply-To: 875ytvbxec.fsf.ref@yahoo.com


As of 2028df78, font backends are required to use s->font instead of
s->face->font, even in the NS port, because s->face is now set to mouse
face by redisplay independently of terminal specific code.

Every font backend except for nsfont already does that, so it would make
sense to change nsfont to do it correctly as well.  But is there
something I'm missing here?

IOW, I'm suggesting to change the following snippet of nsfont_draw:

  font = (struct nsfont_info *)s->face->font;
  if (font == NULL)
    font = (struct nsfont_info *)FRAME_FONT (s->f);

to

  font = (struct nsfont_info *)s->font;
  if (font == NULL)
    font = (struct nsfont_info *)FRAME_FONT (s->f);

Thanks.



       reply	other threads:[~2021-10-17 13:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <875ytvbxec.fsf.ref@yahoo.com>
2021-10-17 13:20 ` Po Lu [this message]
2021-10-17 13:35   ` DPS font backend uses the wrong font Po Lu
2021-10-17 17:35     ` Alan Third
2021-10-18  0:15       ` Po Lu
2021-10-17 17:32   ` Alan Third

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875ytvbxec.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).