From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Narendra Joshi Newsgroups: gmane.emacs.devel Subject: Re: repeat-mode: Setting `repeat-map' property to a keymap object fails Date: Thu, 25 Nov 2021 19:09:42 +0100 Message-ID: <875ysg1509.fsf@gmail.com> References: <87tug1qoej.fsf@gmail.com> <86y25cvf6p.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12043"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: emacs-devel@gnu.org Cancel-Lock: sha1:uyt7SjAi/u48Gft3rbi/p5bLU3I= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 25 19:11:02 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqJD4-0002uK-MH for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Nov 2021 19:11:02 +0100 Original-Received: from localhost ([::1]:60256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqJD2-0000iI-TE for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Nov 2021 13:11:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58850) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqJBx-0008Hg-Rm for emacs-devel@gnu.org; Thu, 25 Nov 2021 13:09:53 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]:52242) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqJBw-0006Iy-IB for emacs-devel@gnu.org; Thu, 25 Nov 2021 13:09:53 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mqJBt-0001KI-Nk for emacs-devel@gnu.org; Thu, 25 Nov 2021 19:09:49 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280164 Archived-At: Juri Linkov writes: >> I tried to use a `keymap' object as the value of the `repeat-map' >> property of a symbol/command and it failed. I think the change below >> would avoid the problem. The problem is that `boundp` throws an error >> for anything other than a symbol value. >> >> diff --git a/lisp/repeat.el b/lisp/repeat.el >> index 4dcd353e34..32ffb1884f 100644 >> --- a/lisp/repeat.el >> +++ b/lisp/repeat.el >> @@ -416,7 +416,7 @@ repeat-post-hook >> (and (symbolp real-this-command) >> (get real-this-command 'repeat-map))))) >> (when rep-map >> - (when (boundp rep-map) >> + (when (and (symbolp rep-map) (boundp rep-map)) >> (setq rep-map (symbol-value rep-map))) >> (let ((map (copy-keymap rep-map))) > > Thanks, fixed now. > Thanks. I see that it's merged to `emacs-28`. How/when would it end up on the master branch? I am just curious about the overall process. Best, -- Narendra Joshi