From: Michael Heerdegen <michael_heerdegen@web.de>
To: emacs-devel@gnu.org
Cc: "Mattias Engdegård" <mattiase@acm.org>
Subject: Re: master 3447e79f24 1/3: * lisp/emacs-lisp/rx.el: Indent some rx constructs correctly.
Date: Thu, 30 Jun 2022 13:30:51 +0200 [thread overview]
Message-ID: <875ykitml0.fsf@web.de> (raw)
In-Reply-To: <20220629152917.18CFDC01686@vcs2.savannah.gnu.org> ("Mattias Engdegård"'s message of "Wed, 29 Jun 2022 11:29:17 -0400 (EDT)")
Mattias Engdegård <mattiase@acm.org> writes:
> --- a/lisp/emacs-lisp/rx.el
> +++ b/lisp/emacs-lisp/rx.el
> @@ -1110,6 +1110,14 @@ can expand to any number of values."
> (append rx--builtin-forms rx--builtin-symbols)
> "List of built-in rx names. These cannot be redefined by the user.")
>
> +;; Declare Lisp indentation rules for constructs that take 1 or 2
> +;; parameters before a body of RX forms.
> +(dolist (sym '( group-n submatch-n = >=))
> + (put sym 'lisp-indent-function 1))
This is problematic: It changes the indentation behavior of the global
functions, depending on whether "rx.el" has been loaded. Multiline
calls of `=' or `>=' might be rare, but multiline `rx' subexps are rare
as well.
Can we delay such changes until we have some kind of context sensitive
indentation algorithm for Elisp?
TIA,
Michael.
next prev parent reply other threads:[~2022-06-30 11:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165651655670.29289.7898006751120870045@vcs2.savannah.gnu.org>
[not found] ` <20220629152917.48CBCC00BAF@vcs2.savannah.gnu.org>
2022-06-29 17:25 ` master e4df6203e2 3/3: More robust `gnu` pattern (bug#56249) Stefan Monnier
2022-06-29 18:15 ` Mattias Engdegård
2022-06-29 18:55 ` Stefan Monnier
[not found] ` <20220629152917.18CFDC01686@vcs2.savannah.gnu.org>
2022-06-30 11:30 ` Michael Heerdegen [this message]
2022-06-30 12:41 ` master 3447e79f24 1/3: * lisp/emacs-lisp/rx.el: Indent some rx constructs correctly Mattias Engdegård
2022-06-30 13:12 ` Michael Heerdegen
2022-06-30 13:17 ` Visuwesh
2022-06-30 13:24 ` Mattias Engdegård
2022-06-30 14:46 ` Stefan Monnier
2022-07-01 8:21 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ykitml0.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).