From: Akib Azmain Turja <akib@disroot.org>
To: Eli Zaretskii <eliz@gnu.org>, Phil Sainty <psainty@orcon.net.nz>
Cc: emacs-devel@gnu.org
Subject: Re: [C source] Inconsistent comments on preprocessor conditionals
Date: Fri, 08 Jul 2022 19:55:05 +0600 [thread overview]
Message-ID: <875yk73e12.fsf@disroot.org> (raw)
In-Reply-To: <83y1x33eum.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Sat, 09 Jul 2022 01:33:26 +1200
>> From: Phil Sainty <psainty@orcon.net.nz>
>> Cc: Akib Azmain Turja <akib@disroot.org>, emacs-devel@gnu.org
>>
>> On 2022-07-09 00:55, Eli Zaretskii wrote:
>> > You mean, the comment for the #endif line? It doesn't really matter
>> > how you comment that, because both comments tell the same: the
>> > #ifdef'ed conditional block ends here. The differences in this case
>> > are purely stylistic.
>>
>> The "#endif /* not FOO */" version provides the extra information that
>> there *is* an "#else" clause
>
> No, it doesn't, because the conditional could start with #ifndef
> instead.
Then we can do like the following:
--8<---------------cut here---------------start------------->8---
#ifndef FOO
...
#else /* not !FOO */
...
#endif /* not !FOO */
--8<---------------cut here---------------end--------------->8---
Very confusing though.
--
Akib Azmain Turja
This message is signed by me with my GnuPG key. It's fingerprint is:
7001 8CE5 819F 17A3 BBA6 66AF E74F 0EFA 922A E7F5
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2022-07-08 13:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 12:47 [C source] Inconsistent comments on preprocessor conditionals Akib Azmain Turja
2022-07-08 12:55 ` Eli Zaretskii
2022-07-08 13:33 ` Phil Sainty
2022-07-08 13:37 ` Eli Zaretskii
2022-07-08 13:55 ` Akib Azmain Turja [this message]
2022-07-08 14:01 ` Eli Zaretskii
2022-07-08 14:21 ` Phil Sainty
2022-07-08 16:28 ` Sergey Organov
2022-07-08 19:54 ` Stefan Monnier
2022-07-11 12:42 ` Akib Azmain Turja
2022-07-08 12:57 ` Po Lu
2022-07-08 13:47 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yk73e12.fsf@disroot.org \
--to=akib@disroot.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=psainty@orcon.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).