From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.devel Subject: Re: ELPA submission: python-import Date: Sat, 30 Jul 2022 10:56:22 +0200 Message-ID: <875yjfkmh5.fsf@gmail.com> References: <87v8rguhry.fsf@gmail.com> <83k07w6j87.fsf@gnu.org> <87r124ue1w.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21395"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org, Philip Kaludercic To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 30 10:58:49 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oHiJ7-0005OP-0t for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Jul 2022 10:58:49 +0200 Original-Received: from localhost ([::1]:51748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oHiJ4-00059u-2u for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Jul 2022 04:58:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHiGp-0003jQ-KV for emacs-devel@gnu.org; Sat, 30 Jul 2022 04:56:28 -0400 Original-Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]:38553) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oHiGo-0005D3-2d; Sat, 30 Jul 2022 04:56:27 -0400 Original-Received: by mail-ed1-x529.google.com with SMTP id a89so8266683edf.5; Sat, 30 Jul 2022 01:56:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :user-agent:mime-version; bh=kJfOgQEtgFvZtgttJysmX32PxFL1Hj/qOf6VazdEX/4=; b=cPl4cGxnv7QXFTNPvaykiXJs/0NTHcJ19BLJ44kkYQWPvVnePR89et/DkVPAUJsr8o igpUfk4cU3JN03bs+4X9qTJg1BYmRzbODLGt/DEvSBV4oTvHITe6mth8WjT9042itqHu BdnmjDxEq82n/2UtSfrCmRxJfhy8P4S+ruq4B8Z5eJeuGMpWWeeobRTPusNqFjy0GodY P1qit1Cco5Ar2Agco24Nyhi80MX4aTtsH8wZdcvrXdy/GjMic5ajuQ0ClV5gDZJD1W+H a3Fh3m+kJ+Hki584u33SPOc183gE2tiBZD5Y6sXaS1oxtLJW70Jb319XGPzFT8jV85OL tz1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:user-agent:mime-version; bh=kJfOgQEtgFvZtgttJysmX32PxFL1Hj/qOf6VazdEX/4=; b=FmtkVaTasV8kDAp82/YET05utlCsFQWwe+sJ0q00wyWdl1HrNcUGxAweJIBIOOlUDW E+dZnG3jfjLCBUh2MGu0UBYj2BReiW7nVMc8NgQWQfW0WzC280qMmrXPMrZ6RTyTd4wK +d8ZwtxnvnOqF+x/iNr68n3UEDJMvIOBaaHxo9QpFMAD4I58MTxakQ7JEPvTegairvhB liM2N6/rlwmEWWYwl9CoVUvJ8u+g5EAOyYFArHYR8LabpMzQO0ZFgDfWidCKPR99y1oE 2BMsU054kYzybohfiP/sIde6tPcFBJtQQSYEhh+JSpzvGuOp0FvzNxp5GW5WTa8mizZX Zq6Q== X-Gm-Message-State: AJIora8R59ouX3FU8WopYA5V23dqyBdGOiENqfYAXLIJwLCKhJo/Vtg9 bcs0XVnXUTwasu8eQm67c3g= X-Google-Smtp-Source: AGRyM1sxActZgXB2wyjmrrtYovAUnv9emOwwnJ8u3dDhInhLAwOBUGDW1fhTrcYNL7HxuwbSxfeAnQ== X-Received: by 2002:a50:ee92:0:b0:43d:ffb:2258 with SMTP id f18-20020a50ee92000000b0043d0ffb2258mr7071326edr.416.1659171384221; Sat, 30 Jul 2022 01:56:24 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::11cf]) by smtp.gmail.com with ESMTPSA id g14-20020a170906538e00b0072124df085bsm2711410ejo.15.2022.07.30.01.56.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Jul 2022 01:56:23 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Fri, 29 Jul 2022 12:25:53 -0400") Received-SPF: pass client-ip=2a00:1450:4864:20::529; envelope-from=arstoffel@gmail.com; helo=mail-ed1-x529.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292860 Archived-At: On Fri, 29 Jul 2022 at 12:25, Stefan Monnier wrote: >> I suppose two things speaking against it: >> >> - The package depends on two external tools (isort and pyflakes) that >> are popular but neither built-in nor de facto standards. >> >> - Sometimes the heuristics used there can be wrong (e.g. if relative >> imports (IMHO usually a bad idea anyway) are used). I haven't used >> the package enough to judge how much of a problem this is. > > FWIW, I don't find those to be good reasons to keep the code separate. > It's quite common for some parts of the functionality of a major modes > to be less thorough (e.g. depend on the presence of some unusual tool, > or depend on specific conventions, ...): it's not ideal, but it's better > than nothing, and also makes it "obvious" where to improve the code. > IOW it can encourage further improvements. Sounds good then. I'll develop and test the code a bit more locally for a few weeks and then submit a patch. In the meanwhile I'll keep updating the git repo linked in my previous message. Feedback from anyone interested in checking it out is welcome.