From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] Add Agitate package Date: Tue, 27 Sep 2022 20:18:34 +0300 Message-ID: <875yh8wxat.fsf@protesilaos.com> References: <875yh9xsmx.fsf@protesilaos.com> <87ill8er5k.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29514"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Notmuch/0.37 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Sean Whitton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 27 19:46:19 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odEew-0007Wv-DU for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Sep 2022 19:46:18 +0200 Original-Received: from localhost ([::1]:49408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odEev-0002Vl-G3 for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Sep 2022 13:46:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odEEG-0000L8-IZ for emacs-devel@gnu.org; Tue, 27 Sep 2022 13:18:51 -0400 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:54079) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odEED-0007hF-Vc for emacs-devel@gnu.org; Tue, 27 Sep 2022 13:18:44 -0400 Original-Received: (Authenticated sender: public@protesilaos.com) by mail.gandi.net (Postfix) with ESMTPSA id 3E5F120004; Tue, 27 Sep 2022 17:18:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1664299116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=se9x2kplW37XojBfEXtPL3YbhvOpcGH8LOkZXXQXJbw=; b=X2XTiH82s1MIFMZTrQp4571HZr4YdkxTpl/u0SpYW0RR/P2bdB9oZYn0aMJzk8UysfdBk3 IE43pPznrLKfvd6Qa7dtyDfuZ/x4DUfVksu+fFm8G5+CI66ww+gGeqNzR2je/5nsB0X8Aa UpKYSDiJZ+r9JoIPG5Px2Kr6SRDCHPGGRyf8AIPRjBJg+yx1TOvUk5iccm9p00BWJrzWuv lhvIlvj2IAcwKZYLG8mv8KMvIujzvj28IsdxACXo8Ape0dI7E1Use1NsBpmk5q+xY9nj98 3YbUExCEUQPMr6/NcodyOkKaAzYQD0Bt8SZJh5RV+FlXAMRZ5dNkyJXW1GExmQ== In-Reply-To: <87ill8er5k.fsf@melete.silentflame.com> Received-SPF: none client-ip=217.70.183.200; envelope-from=info@protesilaos.com; helo=relay7-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296362 Archived-At: > From: Sean Whitton > Date: Tue, 27 Sep 2022 09:08:39 -0700 > > Hello Prot, Hello Sean, > On Tue 27 Sep 2022 at 09:01AM +03, Protesilaos Stavrou wrote: > >> I want to install the attached patch on elpa.git. >> >> Agitate is a collection of commands or potentially useful functions >> that expand on the available version control features of Emacs. Those >> are meant to complement a workflow that relies on the built-in Version >> Control framework and its accoutrements ('diff-mode.el', >> 'log-view.el', 'log-edit.el', 'vc-git.el', and potentially others). >> >> The reason I am posting this here is because I want to ask if it is okay >> to publish such a package, given that at least some of its code may be >> better suited for emacs.git directly. I prefer the package format for >> the time being, because it gives me (and others) the chance to refine >> the code and decide on what is worth contributing to core Emacs. > > I just looked through the file. I recently read your prot-vc.el from > your personal Emacs configuration, and I believe that most (or all?) of > Agitate is a cleaned-up version of that? Thanks for taking the time to do that and to write this! You are right: some it is a rewritten version of what I had been using in my own setup. Though I discarded most parts. The idea with the package is to continue with the discarding+refining process, with whatever help from the community. > I think that it is always worth taking a fresh look at one's personal > code and seeing if versions of parts of it might be upstreamable, so > thank you for your work. One does have to accept, as I'm sure you > realise, that some things will be too idiosyncratic or personal to be > much use to others. So it's reasonable to assume, given its origin, > that Agitate is a mixture of things that should eventually go into > emacs.git and things which should not. I agree. > In that case, it doesn't make too much sense to me to add it to ELPA, > but not for the reasons that you give. It's not that code which is > targeting emacs.git cannot go on ELPA first, but it seems to me that > anything on ELPA should be a coherent, singular package. And Agitate > isn't that -- it's a collection of functionality that you're filtering > things out of over time. The part about coherence is the trickiest when it comes to VC because the whole workflow involves different processes, some of which are implemented in vc-*.el, others in log-edit.el, and the like. I think that what I have and am working towards (this is not the finished article) is coherent in terms of workflow. Though I wanted to have this discussion exactly because I may be caught in a bubble and misjudging things. > For myself, I'm looking forward to seeing some of this in core. Yes, that is the end goal: to determine what should be in emacs.git and which form it should take. Thanks again! All the best, Prot -- Protesilaos Stavrou https://protesilaos.com