From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matt Armstrong Newsgroups: gmane.emacs.devel Subject: Re: noverlay branch Date: Sat, 22 Oct 2022 21:49:09 -0700 Message-ID: <875ygb401m.fsf@rfc20.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13247"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 24 02:02:11 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1omkuw-0003F7-Vb for ged-emacs-devel@m.gmane-mx.org; Mon, 24 Oct 2022 02:02:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1omkWQ-00046b-CN for ged-emacs-devel@m.gmane-mx.org; Sun, 23 Oct 2022 19:36:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omSvK-0007AY-6m for emacs-devel@gnu.org; Sun, 23 Oct 2022 00:49:22 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omSvH-0004bs-Fe for emacs-devel@gnu.org; Sun, 23 Oct 2022 00:49:21 -0400 Original-Received: (Authenticated sender: matt@rfc20.org) by mail.gandi.net (Postfix) with ESMTPSA id 6248AFF802; Sun, 23 Oct 2022 04:49:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rfc20.org; s=gm1; t=1666500552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EjtS71SXfpF7LWR3T+xYwAaUjdTQBI3pkN4GdROH+wI=; b=UIek0rPVYc0PTmcGwEOrh+CKUKCOh5mxW3a2HcHBysK3obUSdR/aCnT09KDEkrDirrGWtR 7L54QHUiMe/8lryTrjLy2HSeXxaIJZhjSiMVFBmw32GHTidbwzxH0KAoQauI7vIj013Se5 yyik0syqz1nhLnm4iPSmeL+865jZS4RZgmDD26yy1PWGaNyzWmEP8q1XVEwixfl6RwBgzu N9biWCvNHs9B9gFLkE3SxlO9nkTytES/7r1aJimOREojlFci6WASqUtQGiHpQi0SdJknQB LzcddO/7t9vQoA0K25eDiRvqXSNM1yw+91Vqlx+llHz1m9r/Uc/D9zberIABeg== Original-Received: from matt by naz with local (Exim 4.96) (envelope-from ) id 1omSv7-0027AP-18; Sat, 22 Oct 2022 21:49:09 -0700 In-Reply-To: Received-SPF: pass client-ip=217.70.183.199; envelope-from=matt@rfc20.org; helo=relay9-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:298277 Archived-At: Stefan Monnier writes: > I just updated the noverlay branch to the code in `master` (most of it > was mechanical except for the fact that since the last commit on that > branch we have gotten rid of Lisp_Misc and we moved to pdumper). TLDR: things are looking pretty stable and good on the feature/noverlay branch. If anyone here tested it a month ago and found it lacking, give it another whirl. Stefan, unless I have a flash of insight I'm done with my differential fuzz testing of the noverlay branch's ELisp functions that relate to overlays. I've sent you three patches (see bug#58703 and bug#58706) but with those fixes my test harness now runs hundreds of thousands of randomized operations against with no no difference detected between Emacs master and the feature/noverlay branch. Code at https://git.sr.ht/~matta/emacs/tree/my/overfuzz/item/test/manual/noverlay/overfuzz.el, though I haven't polished it up. There are two calls to 'overlays_in' in buffer.c that I couldn't cover from ELisp: 'disable_line_numbers_overlay_at_eob' and 'mouse_face_overlay_overlaps'. They're both display related. Trying to manually exercise 'disable_line_numbers_overlay_at_eob' I couldn't find any ELisp that set `display-line-numbers-disable' on an overlay, and only two that do it in a text property (vc/log-edit.el and something in helm), so even if there were a bug here I'm not sure anyone would discover it. I haven't looked at mouse_face_overlay_overlaps, but as I move my mouse around different things highlight as expected, and as I narrow the buffer things behave the same on feature/noverlay as they do on master (as far as I can tell).