From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: feature/package+vc 04c4c578c7 3/4: Allow for packages to be installed directly from VCS Date: Sun, 30 Oct 2022 14:51:41 +0000 Message-ID: <875yg1bc02.fsf@posteo.net> References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <87ilkelc10.fsf@posteo.net> <878rl6syg8.fsf@posteo.net> <87zgdjqcu0.fsf@posteo.net> <87zgdivc3f.fsf@posteo.net> <874jvqv2u3.fsf@posteo.net> <875yg6qtbl.fsf@posteo.net> <87ilk33lqk.fsf@posteo.net> <87mt9epqlk.fsf@posteo.net> <87ilk1bgvd.fsf@posteo.net> <87edupbdp0.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15920"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Richard Stallman , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 30 15:52:40 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1op9fz-0003sc-Qv for ged-emacs-devel@m.gmane-mx.org; Sun, 30 Oct 2022 15:52:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1op9f9-0007ab-UN; Sun, 30 Oct 2022 10:51:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op9f8-0007aF-BO for emacs-devel@gnu.org; Sun, 30 Oct 2022 10:51:46 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op9f6-00042K-HA for emacs-devel@gnu.org; Sun, 30 Oct 2022 10:51:46 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id A1FEF240104 for ; Sun, 30 Oct 2022 15:51:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667141502; bh=lDLPvTdSXS/xLpZjFHVk6QaPymbraHenxli6pr7d8kY=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=QO9/96/bSOSVdqmjgRjavx8em3EIitA7QpfZPydFB9e60R63LHwMf1S6PSJyZZ+d3 WUiFJWHclUz4f25S6TdOZhpqyVTsTi/TBswoB5WRblO0qZBSYENHPppOeQQRpWMYxA 0MXC8tvzUS0Gn2BygugWxrD8hH1n3Rc2Qx+qYbvHdtQsZ1g1UvnSUShRflhd3+PRTc w3qcXSDbt2Q7GD0YN5Dz0I1579JpFym0ZtuKLFnGjvccfPwmUkcfhD4arGOI8G0GmJ mA7zK0E/Ig8Eud4X5zl3xnXrzRS9A9HC9ySsBKu7/gjIWAndkmoqjNzKHqm/79oeN6 vjWYorGgMRGKQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N0fPT70Lkz9rxG; Sun, 30 Oct 2022 15:51:41 +0100 (CET) In-Reply-To: (Stefan Monnier's message of "Sun, 30 Oct 2022 10:36:44 -0400") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298819 Archived-At: Stefan Monnier writes: > Philip Kaludercic [2022-10-30 14:15:07] wrote: >> Stefan Monnier writes: >>>> I guess so. Here is a possible patch that should behave close enough to >>>> elpa-admin.el using "blame" >>> >>> Why do you use `blame` rather than `log` like `elpa-admin.el`? >> >> I tried to use log like in elpa-admin.el, but the issue was I had to >> either >> >> 1. Define the generic interface to search for a line using a regular >> expression that is not an Elisp regular expression, and could >> conceivably differ between different VCS that might also implement >> 'last-change'. >> >> 2. Deal with the issue that the Version header might move between >> revisions, meaning that a line range wouldn't do a good job at >> capturing the right commit. > > FWIW, I suspect that your `git blame` will give the same answer as the > corresponding `git log` (it will probably end up using the same code > under the hood), but I don't understand what you mean above. I think > `git log` would accept the exact same `-L` as you use for `git blame` > and will deal with "the issue that the Version header might move" in the > exact same way. Well apparently not, but I am not entirely sure what the issue was. If you want to, I could take a better look at it and figure out if I missed something. >>> Hmm... the code I see in your patch uses `vc-region-history` (which is >>> only supported for Git and Hg, currently, and is fairly difficult to >>> support in a generic way) rather than `vc-annotate`. >>> Am I missing something? >> >> Uh, that is my mistake. I started writing that code yesterday (I >> believe?) and simply forgot what I had used. I'll try to translate that >> into vc-annotate before pushing anything. > > [ Just to be clear, I wasn't implying a preference between `vc-annotate` > and `vc-region-history`. As fallback, they both seem fine to me. ] I think vc-annotate is preferable, as it is more widespread. >> Checking out a specific revision is currently only done right after >> cloning, so this is always a reset. The issue here is that I am trying >> to stay generic and was using 'vc-retrieve-tag' (but perhaps >> 'vc-checkout' would be better), so this is an issue that might have to >> be tackled in vc-git.el... > > I find this part of VC beyond repair: AFAICT the notion of > "tag/snapshot/..." has been defined "on the fly" with a narrow view of > what was needed for one particular situation at a particular time. > > It's probably worth "throwing it out" (well, keeping it on life support) > and introducing a whole new set of operations based on a design that > tries to accommodate all the various related notions out there. I agree, but that issue goes beyond the proposal of feature/package+vc.