From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Payas Relekar Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: use-package Date: Thu, 03 Nov 2022 22:29:56 +0530 Message-ID: <875yfw6kbx.fsf@gmail.com> References: <87lep4jeeb.fsf@gmail.com> <87bkq0gfc9.fsf@posteo.net> <87v8o80xs1.fsf@gmail.com> <87h6zqgc3s.fsf@gmail.com> <87v8o52mkn.fsf@gmail.com> <87v8o5w2c1.fsf@posteo.net> <877d0kbkfm.fsf@gmail.com> <875yg4144y.fsf@gmail.com> <87h6zmj451.fsf@gmail.com> <5EE58F68-8B9E-4DE6-BA20-3A88FFDA6528@posteo.net> <871qqkjwjj.fsf@gmail.com> <87o7to2dfy.fsf@gmail.com> <87y1ssugaf.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33555"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.8.10; emacs 29.0.50 Cc: Stefan Monnier , John Wiegley , emacs-devel To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 03 18:19:25 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqdsC-0008X3-CE for ged-emacs-devel@m.gmane-mx.org; Thu, 03 Nov 2022 18:19:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqdrm-0000lD-7h; Thu, 03 Nov 2022 13:18:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqddk-000263-Ks for emacs-devel@gnu.org; Thu, 03 Nov 2022 13:04:29 -0400 Original-Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqddi-0007iF-Dt; Thu, 03 Nov 2022 13:04:28 -0400 Original-Received: by mail-pf1-x42a.google.com with SMTP id 130so2185918pfu.8; Thu, 03 Nov 2022 10:04:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=OeI4FiryS0O4jEHZ0Sy/1nPTeESMuURotQ0+YLJ+1Qs=; b=iuFOxGWxC74xwdlaVH6U9OvTLL6apq5H0MypEmxDVugzplVDvabOx+Hj8LLV4AsLoR Q5PvnB8wp8egSC3J8I57pjgDkedvO545OslpWa/3zNhuR7J1UGlLlb86XMb8BFZ17xMY yIvLYLiBhmAgdaIBm6P/AmM3inlOA79RWZnHFbhqulXA1K+Vkp36RmLSfdpHPTUb0Edx zksp0Wc9MoIAgfHpdPaO7zYx0NCNTcyUQoOP8PPgSj+avQIrUY//KFgXOFbkWfOiotAr QhVYtdmT2EsgJtwm9EI87R2UcdDQBWh7tNdXBPW79X0e+Li8iCRqLxOG4yEWb1se0eXR tuQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OeI4FiryS0O4jEHZ0Sy/1nPTeESMuURotQ0+YLJ+1Qs=; b=NYvDFjDiaRwUBQd9JybtDMW3D+TudbOMUEYczTBIFjlQdNj+unsgm36/47KTHxMfuH MCDTtHzpirl6zDeC1rtkI7s0GmWwPavgOyf+5Ym5m2Iv8F51WdLE74vq94dbAZmdOSTa yAYUEX05MIhoej5JwSOiFybrMGqNopbTRL/P6yDHTbbly2Kdz3+xgM6ZO78PLnWMzWM8 0/n1kiBtcKbUGm+uPETt/ZHqPHwvjIs1DZrH4neUtcolv5cnXp7GRnJDUUqnGlf4WWKB hjLe0oDVhHkmugO3gO170Uwi9DF/QzcmdXXK/JbJxDuefzEuZCd2JUh9t6KgSk6pOiri p8pA== X-Gm-Message-State: ACrzQf0h/dyhS75v0/brERCBrtG7yXW8qLXaAK5j1De3HwREw5cBKXpB V0wkeu4hA9cSDfIxuzBOrCw= X-Google-Smtp-Source: AMsMyM4k+7WTwrK0oQAw7MzI+k5KB4ICKQildk6AJV+OJO2oihb5JpZYgmISxIlHFzS3lg7Pk8sZ/A== X-Received: by 2002:a63:194b:0:b0:457:7295:8de0 with SMTP id 11-20020a63194b000000b0045772958de0mr27314318pgz.612.1667495062300; Thu, 03 Nov 2022 10:04:22 -0700 (PDT) Original-Received: from localhost ([150.107.26.17]) by smtp.gmail.com with ESMTPSA id w189-20020a6282c6000000b0056c04dee930sm983594pfd.120.2022.11.03.10.04.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Nov 2022 10:04:21 -0700 (PDT) In-reply-to: <87y1ssugaf.fsf@posteo.net> Received-SPF: pass client-ip=2607:f8b0:4864:20::42a; envelope-from=relekarpayas@gmail.com; helo=mail-pf1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 03 Nov 2022 13:18:57 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299084 Archived-At: Philip Kaludercic writes: > Payas Relekar writes: > >> My understanding is that we only need to add copyrights to the file >> because entire repo is cloned to GNU machines. But even after adding >> copyright headers, IMO adding doc/* to :ignored-files is the right thing >> to do as it does not serve users directly. > > I can imagine that replacing "doc/*" with "doc/" might help, as > `elpaa--copyright-files' doesn't appear to do any globing, instead just > tries to find the file using `member' (ie. using a string comparison > and not even `file-equal-p'). Do you mean in .elpaignore? Because doc/ is not added to :ignored-files right now. >> ======== Building tarball archive-devel/use-package-2.4.4.0.20221103.163652.tar... >> Build error for archive-devel/use-package-2.4.4.0.20221103.163652.tar: (error "Error-indicating exit code in elpaa--call-sandboxed: >> bwrap: execvp makeinfo: No such file or directory >> ") > > This is suspicious, where is makeinfo located? Perhaps you can find out > more if you set the environmental variable "ELPA_DEBUG"? I did not set this variable. What should its value be? >> In toplevel form: >> packages/use-package/doc/setup-ox-hugo.el:192:51: Warning: reference to free variable `ox-hugo-default-lisp-directory' >> packages/use-package/doc/setup-ox-hugo.el:215:21: Warning: reference to free variable `org-emphasis-regexp-components' >> packages/use-package/doc/setup-ox-hugo.el:222:33: Warning: Unused lexical argument `file' >> packages/use-package/doc/setup-ox-hugo.el:224:4: Error: `add-to-list' can't use lexical var `ob-lang-alist'; use `push' or `cl-pushnew' >> packages/use-package/doc/setup-ox-hugo.el:224:4: Error: `add-to-list' can't use lexical var `ob-lang-alist'; use `push' or `cl-pushnew' >> packages/use-package/doc/setup-ox-hugo.el:230:56: Warning: Unused lexical argument `body' >> packages/use-package/doc/setup-ox-hugo.el:238:11: Warning: assignment to free variable `org-confirm-babel-evaluate' >> packages/use-package/doc/setup-ox-hugo.el:241:11: Warning: assignment to free variable `org-export-headline-levels' >> packages/use-package/doc/setup-ox-hugo.el:242:19: Warning: reference to free variable `org-export-exclude-tags' >> packages/use-package/doc/setup-ox-hugo.el:242:19: Warning: assignment to free variable `org-export-exclude-tags' >> >> In end of data: >> packages/use-package/doc/setup-ox-hugo.el:238:40: Warning: the function `ox-hugo-org-confirm-babel-evaluate-fn' is not known to be defined. >> packages/use-package/doc/setup-ox-hugo.el:218:4: Warning: the function `org-set-emph-re' is not known to be defined. >> packages/use-package/doc/setup-ox-hugo.el:208:4: Warning: the function `org-hugo-export-wim-to-md' is not known to be defined. >> packages/use-package/doc/setup-ox-hugo.el:75:49: Warning: the function `vc-git-root' is not known to be defined. >> make: *** [GNUmakefile:119: packages/use-package/doc/setup-ox-hugo.elc] Error 1 > > The ignored files are just not included into the tarball (see > `elpaa--make-one-tarball-1' in elpa-admin.el), but they are still byte > compiled AFAIK. That feels like waste of CPU cycles. > I will once more argue that it might be easier to remove these files > from the repository entirely. As much as I agree, that would be John's call. He does maintain separate webpage for use-package keywords, but I'll say Github already renders README well enough (and also uses ox-hugo under the hood IIRC). John, WDYT? --