From: Philip Kaludercic <philipk@posteo.net>
To: emacs-devel@gnu.org
Cc: Marek Labos <marek@syftapp.com>
Subject: Re: [nongnu] elpa/idris-mode e7e2a6c3bc 3/8: Remove dependency on if-let* defined in subr-x
Date: Fri, 11 Nov 2022 16:00:51 +0000 [thread overview]
Message-ID: <875yfl32h8.fsf@posteo.net> (raw)
In-Reply-To: <20221111115858.91A0EC0E4CB@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Fri, 11 Nov 2022 06:58:58 -0500 (EST)")
ELPA Syncer <elpasync@gnu.org> writes:
> branch: elpa/idris-mode
> commit e7e2a6c3bc56a72b3edb8dedef7f4b3c63bcd1f8
> Author: Marek Labos <marek@syftapp.com>
> Commit: Marek Labos <marek@syftapp.com>
>
> Remove dependency on if-let* defined in subr-x
>
> Why:
> to test if this fixes issue `(seq-find .. ) is a malformed function`
> https://github.com/idris-hackers/idris-mode/pull/558#issuecomment-1307149527
> ---
> idris-commands.el | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/idris-commands.el b/idris-commands.el
> index 9e77008042..a11bba322a 100644
> --- a/idris-commands.el
> +++ b/idris-commands.el
> @@ -960,11 +960,12 @@ Inspired by `cider-switch-to-last-clojure-buffer'
> https://github.com/clojure-emacs/cider"
> (interactive)
> (if (derived-mode-p 'idris-repl-mode)
> - (if-let* ((a-buf (seq-find
> - (lambda (b) (eq 'idris-mode (buffer-local-value 'major-mode b)))
> - (buffer-list))))
> - (pop-to-buffer a-buf `(display-buffer-reuse-window))
> - (user-error "No Idris buffer found"))
> + (let ((idris-buffer (seq-find
> + (lambda (b) (eq 'idris-mode (buffer-local-value 'major-mode b)))
> + (buffer-list))))
> + (if idris-buffer
> + (pop-to-buffer idris-buffer `(display-buffer-reuse-window))
> + (user-error "No Idris buffer found")))
> (user-error "Not in a Idris REPL buffer")))
>
> (defun idris-quit ()
Are you sure that subr-x was loaded? It is usually best to have a
(eval-when-compile (require 'subr-x))
at the top of the file so that those macros get simplified away at
compile time.
prev parent reply other threads:[~2022-11-11 16:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166816793805.30580.17048508686295430872@vcs2.savannah.gnu.org>
[not found] ` <20221111115858.91A0EC0E4CB@vcs2.savannah.gnu.org>
2022-11-11 14:00 ` [nongnu] elpa/idris-mode e7e2a6c3bc 3/8: Remove dependency on if-let* defined in subr-x Stefan Monnier
2022-11-11 16:00 ` Philip Kaludercic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yfl32h8.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=emacs-devel@gnu.org \
--cc=marek@syftapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).