From: Po Lu <luangruo@yahoo.com>
To: emacs-devel@gnu.org
Cc: "F. Jason Park" <jp@neverwas.me>
Subject: Re: emacs-29 00de296d1b 3/3: Simplify erc-sasl's auth-source API
Date: Tue, 29 Nov 2022 14:07:56 +0800 [thread overview]
Message-ID: <875yeywawz.fsf@yahoo.com> (raw)
In-Reply-To: <20221129051801.9344CC0009E@vcs2.savannah.gnu.org> (Amin Bandali's message of "Tue, 29 Nov 2022 00:18:01 -0500 (EST)")
Amin Bandali <bandali@gnu.org> writes:
> branch: emacs-29
> commit 00de296d1b4f629fd828cdeff588bb4f742d9ffe
> Author: F. Jason Park <jp@neverwas.me>
> Commit: Amin Bandali <bandali@gnu.org>
>
> Simplify erc-sasl's auth-source API
>
> * doc/misc/erc.texi: Revise descriptions in SASL chapter to reflect
> simplified auth-source options.
>
> * lisp/erc/erc-sasl.el (erc-sasl-password,
> erc-sasl-auth-source-function): Revise doc strings.
> (erc-sasl-auth-source-password-as-host): New function to serve as
> more useful choice for option `erc-sasl-auth-source-function'.
> (erc-sasl--read-password): Promote auth-source to pole position, above
> an explicit string and `:password'.
>
> * test/lisp/erc/erc-sasl-tests.el (erc-sasl--read-password--basic):
> Massage tests to conform to simplified `erc-sasl-password'
> API. (Bug#29108.)
Was such a big change really a regression fix, suitable for emacs-29?
next parent reply other threads:[~2022-11-29 6:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166969908095.16328.16275737650099622826@vcs2.savannah.gnu.org>
[not found] ` <20221129051801.9344CC0009E@vcs2.savannah.gnu.org>
2022-11-29 6:07 ` Po Lu [this message]
2022-11-29 14:44 ` emacs-29 00de296d1b 3/3: Simplify erc-sasl's auth-source API F. Jason Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yeywawz.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=emacs-devel@gnu.org \
--cc=jp@neverwas.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).