From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Basil Contovounesios Newsgroups: gmane.emacs.devel Subject: Re: master 8aef401b4f: LAP optimiser: more stack reduction hoisting Date: Tue, 14 Feb 2023 18:30:33 +0000 Message-ID: <875yc4t7zq.fsf@tcd.ie> References: <167630393968.3716.18264966967495324218@vcs2.savannah.gnu.org> <20230213155859.EC4E9C13915@vcs2.savannah.gnu.org> <87pmadrxbh.fsf@tcd.ie> <523BE084-9B5F-4F2B-AC24-BB2859D191AE@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37499"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 14 19:31:24 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pS05L-0009aT-SF for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Feb 2023 19:31:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pS04s-0005Ku-Cg; Tue, 14 Feb 2023 13:30:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pS04g-0005CU-5a for emacs-devel@gnu.org; Tue, 14 Feb 2023 13:30:47 -0500 Original-Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pS04a-0002pu-Kb for emacs-devel@gnu.org; Tue, 14 Feb 2023 13:30:40 -0500 Original-Received: by mail-wm1-x32c.google.com with SMTP id n13so11597469wmr.4 for ; Tue, 14 Feb 2023 10:30:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R9+ZC6DkA8ArWjq5pWqQRvgIJVmx2zXzk8Jdf8/PGcw=; b=WVQ1nG5X0QcpQ8nXcKRjVujbMx+UbFufh4llr2EhxZcjRvzOlsFPRyBsshnAXAnzGk w4jDT84pjrSKpbfrejxWdm9TCU1jDRr1DgnsbM8ZYFjTeochn7kc/XKggckh3QZRLccO mo9D5JWSu/RdjEVypEnSIDaWcR+oVuHDZ7Nv1dJX5O1tkVXnt8wG7ioc6SknNr2Vy4Rt YsCW07Vi+C0mEtjBfjsiDPPRcnBRnZ03SmlQLsbPnR6/MHQdBHHH7rV2TH7QSpjVgV3/ o9syakPXrY7u6WfbzA7W76Ej53fkibLQZD78UvQVHK9sfEyszAF0h7c6ebb8BlKqD/ii 1MOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=R9+ZC6DkA8ArWjq5pWqQRvgIJVmx2zXzk8Jdf8/PGcw=; b=F+YWMgCETLLpCQmG5pjSjYSRk8PZfqDagWRNFD8WOk50Z2l1hgfuiHduxqhiCQ4Lt1 cRFgYxu2f1t9y9Doj2OT5g1nRF/7ynLOgYH0/tgHTCTSM5jg3wLtaRre+X01OskMivzw j5UtFWVxq9ww4tWhQWCYHT0bCIS4tlXNPjJUh5VEKlMAu5oZk99fbqnVfzts9aVZ5bLC kz0HcN0STNU9XES4JvJXv2sl7F/z0st1ZeAoa9nb3w6vA65Ot/1UkNZekHEUmlmuXrxU uDbK6GoJ+MI7unIfSpJzZdX4j5TR1VuoKbGo4rsee2iHwLBmsn5hqwcQlWHtSiKNt4ad Szkw== X-Gm-Message-State: AO0yUKWhGyymq5XfMWbElePgFmPadaAI8Aci0v0G41vakamC+JJ+RGgR CLj+5jpHKbHuLtx/yQqtL58QkFtNZ00TDm0x X-Google-Smtp-Source: AK7set9MhdRf6U+mEFsWQDhFwGFH4GIF6i6bGxStkTVB/DE8ZFdurUT+fAJb5rnpRp6oFCJ0YDhEkQ== X-Received: by 2002:a05:600c:54e8:b0:3d3:4007:9c88 with SMTP id jb8-20020a05600c54e800b003d340079c88mr2812017wmb.18.1676399434646; Tue, 14 Feb 2023 10:30:34 -0800 (PST) Original-Received: from localhost ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id s12-20020a05600c45cc00b003dfe5190376sm19231579wmo.35.2023.02.14.10.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Feb 2023 10:30:34 -0800 (PST) In-Reply-To: <523BE084-9B5F-4F2B-AC24-BB2859D191AE@acm.org> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Tue, 14 Feb 2023 17:29:28 +0100") Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=contovob@tcd.ie; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303286 Archived-At: Mattias Engdeg=C3=A5rd [2023-02-14 17:29 +0100] wrote: > 13 feb. 2023 kl. 23.54 skrev Basil L. Contovounesios : > >> I don't immediately spot anything wrong with the test > > Indeed, this was a somewhat roundabout LAP peephole bug, triggered by the= change > you found by bisection but actually caused by a botched refactoring a bit > earlier, and ultimately by much older code. It should be fixed now. Great, thanks! --=20 Basil