From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change. Date: Sun, 07 May 2023 17:16:31 +0000 Message-ID: <875y94f4eo.fsf@posteo.net> References: <168335548287.8529.4912240840977468283@vcs2.savannah.gnu.org> <20230506064443.56C75C22F15@vcs2.savannah.gnu.org> <59835735-faa0-4096-e491-35ec92964b7a@gutov.dev> <831qjthhm8.fsf@gnu.org> <715cdac6-83f6-6907-2ff8-3b33381f3487@gutov.dev> <83zg6hg29c.fsf@gnu.org> <83ttwpfvcr.fsf@gnu.org> <83h6spfose.fsf@gnu.org> <35df1362-fd92-9424-97d0-df3479414677@gutov.dev> <83edntfm6e.fsf@gnu.org> <667d5cc1-4a3c-5cd4-21c0-adff89cea769@gutov.dev> <834jopfdwz.fsf@gnu.org> <83v8h4elki.fsf@gnu.org> <87h6sofs02.fsf@posteo.net> <83r0rsebcf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32496"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 07 19:16:45 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvi05-0008Iu-7R for ged-emacs-devel@m.gmane-mx.org; Sun, 07 May 2023 19:16:45 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvhzy-0006uH-2l; Sun, 07 May 2023 13:16:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvhzw-0006u3-Lz for emacs-devel@gnu.org; Sun, 07 May 2023 13:16:36 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvhzu-00023I-Kd for emacs-devel@gnu.org; Sun, 07 May 2023 13:16:36 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id E2412240170 for ; Sun, 7 May 2023 19:16:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1683479792; bh=mmagVOWx4CLuKlB78bMqCTk9Y/pPTi59P/Ks3NtfHG4=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=Q2A/GoLdRTRAg8JZ7XRASJksytm550r0B8PbQ9u7P3BawDnYMUmnNJSgEwXzIwRDl sofBfUlQ6Ge5gq/FlN/yyhBtBEtErh5kxZYy8ttCAB9/FXDdmMJb+cQCIqyUtbfcDR uAJLj9caseIx/4PsFk+Bkl5VsL+kHKttopQQta0JCXMsA8IN0cO5S6pzSd4Bo7iyZ0 KMc9HwM61QQ01gKOfyyzkkJpndgDZ8XiamN+DqJdXwrSbXc9wyeYMhkH3uT6/0Ya70 Z6MiDAQIVlzC9AzVAU8SdejcwOeIrCVcDNhNFbWPuUntvOIqsiwDZdP2v9u7Z7kuLe xqLTaW3aM9+/Q== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QDrgM6Jrlz9rxF; Sun, 7 May 2023 19:16:31 +0200 (CEST) In-Reply-To: <83r0rsebcf.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 07 May 2023 12:32:00 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305962 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: Dmitry Gutov , monnier@iro.umontreal.ca, >> emacs-devel@gnu.org >> Date: Sun, 07 May 2023 08:46:53 +0000 >> >> Eli Zaretskii writes: >> >> > I think it better did, because using "U" would upgrade Eglot and >> > use-package in Emacs 28 and before. So we should give users who want >> > that the capability of keeping that workflow in Emacs 29, if only as >> > opt-in behavior. >> >> "Workflow" is really to high of a term for the problem being discussed >> here. Installing packages is not a periodical thing people to on a >> regular basis. > > Since we are talking about an optional feature, it will suit this > well, I think. The target audience for this are those users who were > used to upgrade Eglot regularly when it was not a core package. > Likewise for other packages that would be brought into core in the > future. > >> > Also, "/ u" should ideally show built-in packages as well, when >> > package-install-upgrade-built-in is non-nil. >> >> So the point here would be that a user who enables this option, regards >> any newer version of a core-package on ELPA as something that should be >> installed? > > Yes. > >> Perhaps this is a tangent, but what would happen if a third-party >> repository like MELPA adds a package with the same name as a core >> package? > > This problem exists today already, with non-core packages. Right? > >> > Philip, can these two changes be implemented safely for Emacs 29? >> >> It certainly can be done. > > I'd appreciate if you could show a patch that we could then consider. > TIA. This is an initial, quick sketch: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 2892728ebd9..4c85db1aedb 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -3740,7 +3740,9 @@ package-menu--find-upgrades ;; ENTRY is (PKG-DESC [NAME VERSION STATUS DOC]) (let ((pkg-desc (car entry)) (status (aref (cadr entry) 2))) - (cond ((member status '("installed" "dependency" "unsigned" "external")) + (cond ((member status (append + '("installed" "dependency" "unsigned" "external") + (and package-install-upgrade-built-in '("built-in")))) (push pkg-desc installed)) ((member status '("available" "new")) (setq available (package--append-to-alist pkg-desc available)))))) @@ -3749,8 +3751,10 @@ package-menu--find-upgrades (let* ((name (package-desc-name pkg-desc)) (avail-pkg (cadr (assq name available)))) (and avail-pkg - (version-list-< (package-desc-priority-version pkg-desc) - (package-desc-priority-version avail-pkg)) + (or (version-list-< (package-desc-priority-version pkg-desc) + (package-desc-priority-version avail-pkg)) + (and package-install-upgrade-built-in + (package--active-built-in-p pkg-desc))) (push (cons name avail-pkg) upgrades)))) upgrades)) --=-=-= Content-Type: text/plain but on my system, it immediately suggests upgrading 24 packages, which is a lot. -- Philip Kaludercic --=-=-=--