From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: dict Date: Sat, 20 May 2023 19:11:12 +0000 Message-ID: <875y8m95tb.fsf@posteo.net> References: <834joj55pt.fsf@gnu.org> <87ednnvtt6.fsf@posteo.net> <875y8ywwko.fsf@posteo.net> <83zg69br5f.fsf@gnu.org> <83ednj9sw2.fsf@gnu.org> <837ct5x5v6.fsf@gnu.org> <83sfbtvii4.fsf@gnu.org> <83h6s9vdft.fsf@gnu.org> <871qjb9cd6.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32986"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Eshel Yaron Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 20 21:12:13 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q0Rzx-0008Oq-Hq for ged-emacs-devel@m.gmane-mx.org; Sat, 20 May 2023 21:12:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q0Rz7-00045I-4s; Sat, 20 May 2023 15:11:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q0Rz5-000455-Nh for emacs-devel@gnu.org; Sat, 20 May 2023 15:11:19 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q0Rz2-0000zW-4I for emacs-devel@gnu.org; Sat, 20 May 2023 15:11:19 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 0F8CC240028 for ; Sat, 20 May 2023 21:11:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1684609874; bh=EM1MJqvS4nmbf6W+OrF99WaFxNc61FqG0RLBnXjhBgg=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=gMDrLRpQV5pOsxa/gp0iGDkDt2YtrT1raIXpNKTiC+HXlJLCmfm4QpXLA3xlVOZgF hwjLRdOjPCN9gEqMXxGY0FTzq9BCFW8UUQMn7WOGm8M6h6XS7liPupjRqf7Kkx1BCV 8JK5OYmKezWeqBFLzvV4HIr26Mjgsxc4LaHp8NBFvLwWALgoN0TTIFwR6o9j6dAXH8 35ci8tGJULa1xayis6wqcnU32o/lfbEQktliOSS+GngZPD9TQtBxCGqMDFbdz4emNJ apkX+w1myzgbZ2hFIUC3A2PzlY/V4fr94+CnvTXe5NQNil4/HTuvcMd6apB7Hd5a1l nc5bl33O8z7uA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QNtbj415Jz6twf; Sat, 20 May 2023 21:11:13 +0200 (CEST) In-Reply-To: (Eshel Yaron's message of "Sat, 20 May 2023 21:27:22 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306238 Archived-At: Eshel Yaron writes: >>> +(defcustom dictionary-display-definition-function nil >>> + "Function to use for displaying dictionary definitions. >>> +It is called with three string arguments: the word being defined, >>> +the dictionary name, and the full definition." >>> + :type '(choice (const :tag "Dictionary buffer" nil) >>> + (const :tag "Help buffer" >>> + dictionary-display-definition-in-help-buffer) >>> + (function :tag "Custom function")) >>> + :version "30.1") >> >> What is the reason for having this option fallback to nil? I couldn't >> make that out from the patch. If all the other options offer a >> concrete-default function (that you could also call in your own >> function), then it seems inconsistent to not provide this here as well. > > The reason is that, unlike the other options, the default path that > `dictionary-search` takes to displaying a definition is highly coupled > with how it obtains the definition, making it difficult to extract into > a standalone function. That's a refactor I prefer to avoid at this > point. So, if you set `dictionary-display-definition-function` to a > custom function, we use the new function `dictionary-define-word` to > cleanly obtain the definition and let your custom function display it. > If you use the default (nil) value, we let `dictionary-search` call the > "old" function `dictionary-new-search` that both obtains and displays > the definition. OK, I am not familiar with the code and I get that it could take too much effort to refactor this properly right now. >>> +(defun dictionary-define-word (word dictionary) >>> + "Return the definition of WORD in DICTIONARY, or nil if not found." >>> + (dictionary-send-command >>> + (format "define %s \"%s\"" dictionary word)) >>> + (when (and (= (read (dictionary-read-reply)) 150) >>> + (= (read (dictionary-read-reply)) 151)) >> >> I think a memq would be nice here. >> > > No, `memq` would be appropriate if we wanted to check that the > expression `(read (dictionary-read-reply))` evaluates to either 150 or > to 151, but here we want to check that it evaluates 150 and then > afterwards that it evaluates to 151. Whoops, misread that as and `or' and forgot about side-effects. >>> +(defun dictionary-display-definition-in-help-buffer (word dictionary definition) >>> + "Display DEFINITION, the definition of WORD in DICTIONARY." >>> + (let ((help-buffer-under-preparation t)) >>> + (help-setup-xref (list #'dictionary-search word dictionary) >>> + (called-interactively-p 'interactive)) >>> + (with-help-window (help-buffer) >>> + (with-current-buffer (help-buffer) >>> + (insert definition) >>> + (goto-char (point-min)) >>> + (while (re-search-forward (rx "{" >>> + (group-n 1 (* (not (any ?})))) >>> + "}") >>> + nil t) >> >> Perhaps you could explain what is going on here. Why is this pattern >> significant? > > We want to buttonize references to other definitions in the *Help* > buffer, which appear enclosed in curly braces. I've added a comment > explaining this. So the protocol always wraps other definitions in curly braces?