From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: package-vc support for :files keyword Date: Sun, 11 Jun 2023 08:55:03 +0000 Message-ID: <875y7u5qfs.fsf@posteo.net> References: <87sfaz1men.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38056"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Daniel Fleischer Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 11 10:56:05 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q8Grl-0009fO-5m for ged-emacs-devel@m.gmane-mx.org; Sun, 11 Jun 2023 10:56:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q8Gqt-0007jf-1e; Sun, 11 Jun 2023 04:55:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8Gqr-0007jM-F4 for emacs-devel@gnu.org; Sun, 11 Jun 2023 04:55:09 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8Gqp-0002UH-7d for emacs-devel@gnu.org; Sun, 11 Jun 2023 04:55:09 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5BC20240104 for ; Sun, 11 Jun 2023 10:55:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1686473704; bh=bJE76UfHnmmlN0e6A0vQU7va+4EQcRkgIZMDKGna7es=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=X8gnG4gHVsxO/Ep1CclYKRThYzakcKcHxT6agWV0r8F+q22opxojN1z0IK7086zL1 IZUMpX8knJeQh2+a7cundk6zGfgT/ZQQx2PFMgqL6xNR0EKQwVnPd6Txc0U8TCIyb/ URxahSuoIaXgk3NLPmpJ1tda0jo5Y+oktZBW7HChnDigntxf7WEmUWYqGMnKPQJlYr OCLL3yvkL3eQLkPHbBr5Lhk7vMuG9RDg6FaOFDzb/K1Quew5WctDkVKnl0LLBzeKVz /CJLNgPg4o2WRp+I5wIOm1pPz1yPoVZUji9bhocCF1nRyr2ZRokkpULDB1kruBdUG7 fWZ9mneO64xrA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Qf7tb6H12z9rxK; Sun, 11 Jun 2023 10:55:03 +0200 (CEST) In-Reply-To: (Daniel Fleischer's message of "Sat, 10 Jun 2023 17:20:30 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306725 Archived-At: (If possible, try to use a wide reply when responding to these messages, so that I (and anyone else who would want to participate but it not subscribed) get notified directly). Daniel Fleischer writes: > Philip Kaludercic writes: > >> Right, as the primary technical inspiration for package-vc has been >> elpa-admin, and therefore we (re-)use GNU ELPA-style package >> specifications. > > Hi, I wasn't aware there's a style guide for ELPA packages. This is not really a style-guide (which is something I would interpret as concerning the contents of a package), but just a matter of how it would be best for packages and the package archive to interact. >> No, just like `:ignored-files' I do not see a sensible way to implement >> it without compromising on the primary goal mentioned above. > > I don't understand this part: `:ignored-files' is part of the ELPA > documentation and you are saying it's still not supported? It is not supported by package-vc. If you check (emacs) Fetching Package Sources, then you'll see the supported keywords listed under the "Specifying Package Sources" section. Generally speaking, package-vc is a subset of the keywords defined by elpa-admin. >> Generally speaking, this is a style of package development that >> {GNU,NonGNU} ELPA would like to advise against perusing, in favour of >> a one-repo-per-package approach. Do you have a specific reason why you >> think that something like `:{ignored-,}files' are useful in general >> (i.e. not just because of the contingent fact that MELPA has >> popularised this form of development). > > One example is tests; having test files either in the root folder or in > a folder called "tests", how do you prevent them from being evaluated? > They could have additional dev dependencies that you might not want to > have. What is the ELPA guideline about that? Test files are not evaluated/loaded, unless the user does so explicitly or if the package developer were to force it via autoloads. In the former case, I would say that it is probably intended behaviour, in the latter case this is a mistake made by the maintainer. If the file is located under a tests/ directory (or any other name), then it will not be added to the `load-path' to begin with. The point here is, that if a user wants to contribute to a package with tests, the tests shouldn't be hidden or even removed. That is why I'd even say it would be better to add the tests to the main lisp directory, so that it is even easier to load them. -- Philip Kaludercic