From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: buildbot.el Date: Tue, 11 Jul 2023 00:06:12 +0300 Message-ID: <875y6rbhob.fsf@protesilaos.com> References: <87edlyr76o.fsf@ypei.org> <87edlnzzqj.fsf@ypei.org> <875y6tdbvi.fsf@ypei.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35902"; mail-complaints-to="usenet@ciao.gmane.io" To: Yuchen Pei , Emacs Devel mailing list Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jul 10 23:07:13 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qIy6C-00098V-Tb for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Jul 2023 23:07:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qIy5M-00032H-6O; Mon, 10 Jul 2023 17:06:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qIy5K-000328-T9 for emacs-devel@gnu.org; Mon, 10 Jul 2023 17:06:18 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qIy5I-0003cK-Bc for emacs-devel@gnu.org; Mon, 10 Jul 2023 17:06:18 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id D158040007; Mon, 10 Jul 2023 21:06:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1689023174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5ajcPD7bsgAeaeQNpwsPXxpLjE6C0xHohngoQ/I9NXs=; b=Qq7amGIB8HWN0+ncfj0ODUe1gmDyKt44GM2xV0dhbryLM7tqSZanvZFT0Nu9iC1JyLm3N0 wYpCFXrvtIxxUYQuyLnB1rEPlf6uRClkTsBGqDWZQgXZP1EoBQ2tm1rM4jzvL8A+Y1ILt+ S9YtxLlXzorZ8DI0TpanutSxzFqoJd0t8cmGrY9YL9QGjRXWhxDeQ1oZmm2U+sVinqKohn BBTeq6NBC9vPTB+/aS5PzzjOZ55EBJ6sflM5D88ZbeOVIHt6GLIZcHoc2wo/bR7oY7U1It IXSenTBsTvsT5SVJm43cnFRAaAW6j1KHRDLPx3zq00fg7JAy5zeY9G17b+xurQ== In-Reply-To: <875y6tdbvi.fsf@ypei.org> X-GND-Sasl: public@protesilaos.com Received-SPF: none client-ip=217.70.183.194; envelope-from=info@protesilaos.com; helo=relay2-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307734 Archived-At: > From: Yuchen Pei > Date: Sun, 9 Jul 2023 13:04:01 +1000 Hello Yuchen, > On Tue 2023-07-04 21:24:04 +1000, Yuchen Pei wrote: > >> On Mon 2023-06-26 17:53:03 +1000, Yuchen Pei wrote: >> >>> Hello everyone, >>> >>> I would like to submit buildbot.el () >>> to the GNU ELPA. It has been how I interact with Buildbot (except for >>> retrying a build) for a few months now. >> >> Ping, can someone with access to ELPA upload the package please? Or >> are there still issues in the way? > > Ping, any updates? > > According to the ELPA readme on adding a new package[1]: > > --8<---------------cut here---------------start------------->8--- > After 48 hours, or once any issues have been addressed, someone will push > your changes for you. You should probably also subscribe to > [[https://lists.gnu.org/mailman/listinfo/emacs-devel][emacs-devel@gnu.org]], since that's where we discuss about GNU ELPA, and > to [[https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs][bug-gnu-emacs@gnu.org]], since that's where people will report bugs > about your package. > --8<---------------cut here---------------end--------------->8--- > > It has been almost two weeks. Can someone honour the guidelines and push > my package to ELPA please? > > [1] https://git.savannah.gnu.org/cgit/emacs/elpa.git/tree/README I will try to help though note that I have no means of testing buildbot. Before checking the code of the package: * You have assigned copyright to the Free Software Foundation and are the author/maintainer of the 'hcel' and 'luwak' GNU ELPA packages. * The 'buildbot' dependency uses the GPL version 2 and is a member of the Software Freedom Conservancy. Notes about the code in your buildbot.el: 1. The 'buildbot.el' file lacks a terminating comment (the "... ends here" part). Your other files have it. 2. I notice that 'M-x checkdoc' returns a few issues in your files. Though, for example, in 'buildbot-client.el' they seem to be false positives. Addressing those is not a priority. I personally do it so that notes do not crowd out errors/warnings. 3. In 'buildbot-utils.el' the functions 'buildbot-url-fetch-json' and 'buildbot-url-fetch-raw' can be consolidated. 4. In 'buildbot-view.el', you are defining key bindings in many places. It may be easier to have them all in one place where the keymap is defined as a variable. All the best, Protesilaos (or simply "Prot") -- Protesilaos Stavrou https://protesilaos.com