[ELPA] New package: ob-asymptote.el

[ELPA] New package: ob-asymptote.el

[Jarmo Hurri]

Greetings.

I have become the maintainer of Asymptote language support in Org
Babel. My first task is to separate ob-asymptote.el from NonGNU ELPA
package org-contrib into its own separate GNU ELPA package.

The package can be found at

https://github.com/hurrja/ob-asymptote

This is my first time submitting to ELPA. I have signed FSF copyright
papers earlier. I have also just registered into savannah.gnu.org
under username jarmo - just in case it helps. The original author of
the package is Eric Schulte, who is a major contributor in Org mode
and so - to my understanding - must also have signed FSF copyright
papers.

The task of the package is simple - from the commentary:

;; Org-Babel support for evaluating asymptote source code.

This first submission consists of simply copying the file from
org-contrib into a new package. Further documentation and development
work will follow.

All the best,

Jarmo

Re: [ELPA] New package: ob-asymptote.el

[Ihor Radchenko]

Jarmo Hurri <jarmo.hurri@iki.fi> writes:

> This is my first time submitting to ELPA. I have signed FSF copyright
> papers earlier. I have also just registered into savannah.gnu.org
> under username jarmo - just in case it helps. The original author of
> the package is Eric Schulte, who is a major contributor in Org mode
> and so - to my understanding - must also have signed FSF copyright
> papers.

And ob-asymptote used to be a part of Org mode and Emacs, until
https://list.orgmode.org/orgmode/87bl9rq29m.fsf@gnu.org/ So, there
should be no blocker copyright-wise, other than current maintainer's
copyright status, which is clear.

Please, take care to add this package as it was in limbo while it had to
be moved to org-contrib.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [ELPA] New package: ob-asymptote.el

[Jarmo Hurri]

Greetings all!

Jarmo Hurri <jarmo.hurri@iki.fi> writes:

> The package can be found at
>
> https://github.com/hurrja/ob-asymptote

Is this new package package ready to be pushed, since no issues have
come up, and it has been over a week?

All the best,

Jarmo

Re: [ELPA] New package: ob-asymptote.el

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > I don't think there's any question about that.  The issue is that *if*
  > there are consequences for a supported customer redistributing those
  > sources;..

That is the original issue that was raised.

Many other questions have come up, which I think are not real issues;
but I think that after asking people for details and thinking about
them.  It is necessary to check the context before I publish anything
aout this.  That doesn't mean we have forgotten the original issue.


-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Re: [ELPA] New package: ob-asymptote.el

[Jarmo Hurri]

Jarmo Hurri <jarmo.hurri@iki.fi> writes:

>> The package can be found at
>>
>> https://github.com/hurrja/ob-asymptote
>
> Is this new package package ready to be pushed, since no issues have
> come up, and it has been over a week?

A gentle bump.

Jarmo

Re: [ELPA] New package: ob-asymptote.el

[Stefan Kangas]

Jarmo Hurri <jarmo.hurri@iki.fi> writes:

> Jarmo Hurri <jarmo.hurri@iki.fi> writes:
>
>>> The package can be found at
>>>
>>> https://github.com/hurrja/ob-asymptote
>>
>> Is this new package package ready to be pushed, since no issues have
>> come up, and it has been over a week?
>
> A gentle bump.

Is there anything blocking this package from going in?

Re: [ELPA] New package: ob-asymptote.el

[Philip Kaludercic]

Stefan Kangas <stefankangas@gmail.com> writes:

> Jarmo Hurri <jarmo.hurri@iki.fi> writes:
>
>> Jarmo Hurri <jarmo.hurri@iki.fi> writes:
>>
>>>> The package can be found at
>>>>
>>>> https://github.com/hurrja/ob-asymptote
>>>
>>> Is this new package package ready to be pushed, since no issues have
>>> come up, and it has been over a week?
>>
>> A gentle bump.
>
> Is there anything blocking this package from going in?

I don't think so, I am just confused why I appear to not find any
previous discussion on this in the archives.

Re: [ELPA] New package: ob-asymptote.el

[Ihor Radchenko]

Philip Kaludercic <philipk@posteo.net> writes:

>> Is there anything blocking this package from going in?
>
> I don't think so, I am just confused why I appear to not find any
> previous discussion on this in the archives.

Are you asking about removing ob-asymptote from Org and moving it to
external package?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [ELPA] New package: ob-asymptote.el

[Stefan Kangas]

Philip Kaludercic <philipk@posteo.net> writes:

>> Is there anything blocking this package from going in?
>
> I don't think so, I am just confused why I appear to not find any
> previous discussion on this in the archives.

It was discussed previously here:
https://lists.gnu.org/r/emacs-devel/2023-07/msg00339.html

Re: [ELPA] New package: ob-asymptote.el

[Stefan Kangas]

Ihor Radchenko <yantar92@posteo.net> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>>> Is there anything blocking this package from going in?
>>
>> I don't think so, I am just confused why I appear to not find any
>> previous discussion on this in the archives.
>
> Are you asking about removing ob-asymptote from Org and moving it to
> external package?

I thought it was already removed from Org based on the discussion here:

https://lists.gnu.org/r/emacs-devel/2023-07/msg00339.html

Re: [ELPA] New package: ob-asymptote.el

[Ihor Radchenko]

Stefan Kangas <stefankangas@gmail.com> writes:

>>>> Is there anything blocking this package from going in?
>>>
>>> I don't think so, I am just confused why I appear to not find any
>>> previous discussion on this in the archives.
>>
>> Are you asking about removing ob-asymptote from Org and moving it to
>> external package?
>
> I thought it was already removed from Org based on the discussion here:
>
> https://lists.gnu.org/r/emacs-devel/2023-07/msg00339.html

Yes, ob-asymptote has been removed from Org distribution, and it is now
maintained by Jarmo as a separate package.

This thread is about adding ob-asymptote - a separate package - to ELPA. 

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [ELPA] New package: ob-asymptote.el

[Stefan Kangas]

Stefan Kangas <stefankangas@gmail.com> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>>> Is there anything blocking this package from going in?
>>
>> I don't think so, I am just confused why I appear to not find any
>> previous discussion on this in the archives.
>
> It was discussed previously here:
> https://lists.gnu.org/r/emacs-devel/2023-07/msg00339.html

Do you think we could add it now?

Re: [ELPA] New package: ob-asymptote.el

[Philip Kaludercic]

[-- Attachment #1: Type: text/plain, Size: 701 bytes --]

Stefan Kangas <stefankangas@gmail.com> writes:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> Philip Kaludercic <philipk@posteo.net> writes:
>>
>>>> Is there anything blocking this package from going in?
>>>
>>> I don't think so, I am just confused why I appear to not find any
>>> previous discussion on this in the archives.
>>
>> It was discussed previously here:
>> https://lists.gnu.org/r/emacs-devel/2023-07/msg00339.html
>
> Do you think we could add it now?

The requirements section mentioned that "asy-mode" is necessary, but
there is no package for that.  I guess that is a blocker, unless the
information is outdated.

Otherwise, I think a change like this would be nice to have:


[-- Attachment #2: Type: text/plain, Size: 1421 bytes --]

diff --git a/ob-asymptote.el b/ob-asymptote.el
index de99ca3..a088fab 100644
--- a/ob-asymptote.el
+++ b/ob-asymptote.el
@@ -61,20 +61,19 @@ This function is called by `org-babel-execute-src-block'."
                      "pdf"))
          (cmdline (cdr (assq :cmdline params)))
          (in-file (org-babel-temp-file "asymptote-"))
-         (cmd
-	  (concat "asy "
-		  (if out-file
-		      (concat
-		       "-globalwrite -f " format
-		       " -o " (org-babel-process-file-name out-file))
-		    "-V")
-		  " " cmdline
-		  " " (org-babel-process-file-name in-file))))
+         (cmd `("asy"
+                ,@(if out-file
+                      `("-globalwrite" "-f" format
+                        "-o" (org-babel-process-file-name out-file))
+                    "-V")
+                cmdline
+                (org-babel-process-file-name in-file))))
     (with-temp-file in-file
       (insert (org-babel-expand-body:generic
-	       body params
-	       (org-babel-variable-assignments:asymptote params))))
-    (message cmd) (shell-command cmd)
+               body params
+               (org-babel-variable-assignments:asymptote params))))
+    (message (mapconcat #'shell-quote-argument cmd " "))
+    (apply #'call-process "asy" nil nil cmd) ;should "asy" be a user option?
     nil)) ;; signal that output has already been written to file
 
 (defun org-babel-prep-session:asymptote (_session _params)

Re: [ELPA] New package: ob-asymptote.el

[Stefan Kangas]

Philip Kaludercic <philipk@posteo.net> writes:

> The requirements section mentioned that "asy-mode" is necessary, but
> there is no package for that.  I guess that is a blocker, unless the
> information is outdated.

I can't find such a package on MELPA.  Is it distributed elsewhere?

Re: [ELPA] New package: ob-asymptote.el

[Ihor Radchenko]

Stefan Kangas <stefankangas@gmail.com> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>> The requirements section mentioned that "asy-mode" is necessary, but
>> there is no package for that.  I guess that is a blocker, unless the
>> information is outdated.
>
> I can't find such a package on MELPA.  Is it distributed elsewhere?

AFAIK, asy-mode.el is a part of Asymptote language distribution:
https://github.com/vectorgraphics/asymptote/blob/aa9f81bad9478bfe8b2ab5fc5376c19c6c79c708/base/asy-mode.el


-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [ELPA] New package: ob-asymptote.el

[Jarmo Hurri]

Greetings.

Ihor Radchenko <yantar92@posteo.net> writes:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> Philip Kaludercic <philipk@posteo.net> writes:
>>
>>> The requirements section mentioned that "asy-mode" is necessary, but
>>> there is no package for that.  I guess that is a blocker, unless the
>>> information is outdated.
>>
>> I can't find such a package on MELPA.  Is it distributed elsewhere?
>
> AFAIK, asy-mode.el is a part of Asymptote language distribution:
> https://github.com/vectorgraphics/asymptote/blob/aa9f81bad9478bfe8b2ab5fc5376c19c6c79c708/base/asy-mode.el

Yes. For example, in my system - Fedora - asy-mode.el lives in

/usr/share/emacs/site-lisp/asymptote/asy-mode.el

and comes from the package

asymptote-2.85-1.fc38.x86_64 : Descriptive vector graphics language

All the best,

Jarmo

Re: [ELPA] New package: ob-asymptote.el

[Stefan Kangas]

Philip Kaludercic <philipk@posteo.net> writes:

> The requirements section mentioned that "asy-mode" is necessary, but
> there is no package for that.  I guess that is a blocker, unless the
> information is outdated.

Jarmo, could we please delete that part so that we can add this package?

Re: [ELPA] New package: ob-asymptote.el

[Jarmo Hurri]

Greetings.

Stefan Kangas <stefankangas@gmail.com> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>> The requirements section mentioned that "asy-mode" is necessary, but
>> there is no package for that.  I guess that is a blocker, unless the
>> information is outdated.
>
> Jarmo, could we please delete that part so that we can add this
> package?

Done:

https://github.com/hurrja/ob-asymptote

All the best,

Jarmo

Re: [ELPA] New package: ob-asymptote.el

[Philip Kaludercic]

Stefan Kangas <stefankangas@gmail.com> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>> The requirements section mentioned that "asy-mode" is necessary, but
>> there is no package for that.  I guess that is a blocker, unless the
>> information is outdated.
>
> Jarmo, could we please delete that part so that we can add this package?

If the comment is outdated, this shouldn't block adding the package to
ELPA.  I am just not in a position to judge this, as I cannot really
test the package.

Re: [ELPA] New package: ob-asymptote.el

[Ihor Radchenko]

Jarmo Hurri <jarmo.hurri@iki.fi> writes:

>> Philip Kaludercic <philipk@posteo.net> writes:
>>
>> Jarmo, could we please delete that part so that we can add this
>> package?
>
> Done:
>
> https://github.com/hurrja/ob-asymptote

Stefan, may I know if there is anything else blocking the addition?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [ELPA] New package: ob-asymptote.el

[Stefan Kangas]

Ihor Radchenko <yantar92@posteo.net> writes:

> Stefan, may I know if there is anything else blocking the addition?

AFAICT, nothing is blocking it, so I've added it to GNU ELPA.

It should be available within 24-48 hours at:

    https://elpa.gnu.org/packages/ob-asymptote.html

Sorry for the delay in adding it, and thanks again for submitting it to
GNU ELPA.

Re: [ELPA] New package: ob-asymptote.el

[Ihor Radchenko]

Stefan Kangas <stefankangas@gmail.com> writes:

> Ihor Radchenko <yantar92@posteo.net> writes:
>
>> Stefan, may I know if there is anything else blocking the addition?
>
> AFAICT, nothing is blocking it, so I've added it to GNU ELPA.
>
> It should be available within 24-48 hours at:
>
>     https://elpa.gnu.org/packages/ob-asymptote.html

I am thus removing ob-asymptote from org-contrib.
https://git.sr.ht/~bzg/org-contrib/commit/a56fb90b1696bb015abfbb04df08a1ebc589d686

CCing Bastien and Org mailing list as this update might be of interest.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [ELPA] New package: ob-asymptote.el

[Bastien Guerry]

Ihor Radchenko <yantar92@posteo.net> writes:

>> It should be available within 24-48 hours at:
>>
>>     https://elpa.gnu.org/packages/ob-asymptote.html

Good news, thanks!

> I am thus removing ob-asymptote from org-contrib.
> https://git.sr.ht/~bzg/org-contrib/commit/a56fb90b1696bb015abfbb04df08a1ebc589d686

Thanks.

-- 
 Bastien Guerry