* Re: master 1870e2f48a7: Avoid `defconst` for vars which we modify
[not found] ` <20240104234455.0F58DC00344@vcs2.savannah.gnu.org>
@ 2024-01-06 12:55 ` Michael Albinus
2024-01-06 13:16 ` Po Lu
2024-01-06 16:23 ` Stefan Monnier
0 siblings, 2 replies; 7+ messages in thread
From: Michael Albinus @ 2024-01-06 12:55 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Monnier
Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:
Hi Stefan,
> diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el
> index 2f6b526039f..ad36dd53a32 100644
> --- a/lisp/net/tramp.el
> +++ b/lisp/net/tramp.el
> -(fn (SECONDS TIMEOUT-FORMS...) BODY)"
> +\(fn (SECONDS TIMEOUT-FORMS...) BODY)"
> (declare (indent 1) (debug ((form body) body)))
> (let ((seconds (car list))
> (timeout-forms (cdr list)))
I'm not sure, but I vaguely remember that this kind of quoting wasn't
needed anymore since Emacs 27.1. Am I wrong?
Best regards, Michael.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: master 1870e2f48a7: Avoid `defconst` for vars which we modify
2024-01-06 12:55 ` master 1870e2f48a7: Avoid `defconst` for vars which we modify Michael Albinus
@ 2024-01-06 13:16 ` Po Lu
2024-01-06 13:32 ` Michael Albinus
2024-01-06 16:23 ` Stefan Monnier
1 sibling, 1 reply; 7+ messages in thread
From: Po Lu @ 2024-01-06 13:16 UTC (permalink / raw)
To: Michael Albinus; +Cc: emacs-devel, Stefan Monnier
Michael Albinus <michael.albinus@gmx.de> writes:
> I'm not sure, but I vaguely remember that this kind of quoting wasn't
> needed anymore since Emacs 27.1. Am I wrong?
Only so long as we still want to support editing our files with Emacs 26
and earlier, where fontification and other navigation commands rely on
open-paren-in-column-0-is-defun-start, I think.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: master 1870e2f48a7: Avoid `defconst` for vars which we modify
2024-01-06 13:16 ` Po Lu
@ 2024-01-06 13:32 ` Michael Albinus
0 siblings, 0 replies; 7+ messages in thread
From: Michael Albinus @ 2024-01-06 13:32 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel, Stefan Monnier
Po Lu <luangruo@yahoo.com> writes:
Hi,
>> I'm not sure, but I vaguely remember that this kind of quoting wasn't
>> needed anymore since Emacs 27.1. Am I wrong?
>
> Only so long as we still want to support editing our files with Emacs 26
> and earlier, where fontification and other navigation commands rely on
> open-paren-in-column-0-is-defun-start, I think.
We're speaking about tramp.el, which has as Package-Requires ((emacs "27.1"))
(see file trampver.el). I don't think we shall support editing by an older
Emacs version, and we shouldn't keep such compatibility code forever.
Best regards, Michael.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: master 1870e2f48a7: Avoid `defconst` for vars which we modify
2024-01-06 12:55 ` master 1870e2f48a7: Avoid `defconst` for vars which we modify Michael Albinus
2024-01-06 13:16 ` Po Lu
@ 2024-01-06 16:23 ` Stefan Monnier
2024-01-06 16:48 ` Michael Albinus
1 sibling, 1 reply; 7+ messages in thread
From: Stefan Monnier @ 2024-01-06 16:23 UTC (permalink / raw)
To: Michael Albinus; +Cc: emacs-devel
> I'm not sure, but I vaguely remember that this kind of quoting wasn't
> needed anymore since Emacs 27.1. Am I wrong?
We've fixed most places that get tripped up, yes, but
`outline-minor-mode` still uses a simple regexp and thus gets confused.
I wouldn't be surprised if there are others out there.
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: master 1870e2f48a7: Avoid `defconst` for vars which we modify
2024-01-06 16:23 ` Stefan Monnier
@ 2024-01-06 16:48 ` Michael Albinus
2024-01-06 21:47 ` Stefan Monnier
0 siblings, 1 reply; 7+ messages in thread
From: Michael Albinus @ 2024-01-06 16:48 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
Hi Stefan,
>> I'm not sure, but I vaguely remember that this kind of quoting wasn't
>> needed anymore since Emacs 27.1. Am I wrong?
>
> We've fixed most places that get tripped up, yes, but
> `outline-minor-mode` still uses a simple regexp and thus gets confused.
Well, we're speaking 'bout Tramp Lisp files. I don't see how they will
be affected by `outline-minor-mode`. I really like to remove this \(
quoting from Tramp sources where possible. Is there a real blocker for this?
--8<---------------cut here---------------start------------->8---
# grep '^\\(' lisp/net/tramp*.el
lisp/net/tramp.el:\(FUNCTION FILE). FUNCTION is responsible to extract user names and host
lisp/net/tramp.el:\(replace \"xxx\" and \"yyy\" by the remote user and host name,
lisp/net/tramp.el:\(like \"ssh\"), because setting `tramp-chunksize' to non-nil decreases
lisp/net/tramp.el:\(fn (SECONDS TIMEOUT-FORMS...) BODY)"
lisp/net/tramp-sh.el:\(FORMAT ENCODING DECODING)
lisp/net/tramp-sh.el:\(FORMAT ENCODING DECODING [TEST])
lisp/net/tramp-sh.el:\(COMPRESS DECOMPRESS)
--8<---------------cut here---------------end--------------->8---
> I wouldn't be surprised if there are others out there.
Sure. But we shall fix these cases when they appear.
> Stefan
Best regards, Michael.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: master 1870e2f48a7: Avoid `defconst` for vars which we modify
2024-01-06 16:48 ` Michael Albinus
@ 2024-01-06 21:47 ` Stefan Monnier
2024-01-07 8:39 ` Michael Albinus
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Monnier @ 2024-01-06 21:47 UTC (permalink / raw)
To: Michael Albinus; +Cc: emacs-devel
> Well, we're speaking 'bout Tramp Lisp files. I don't see how they will
> be affected by `outline-minor-mode`.
I use `outline-minor-mode` for `emacs-lisp-mode`.
I don't go around escaping all the ( that are out there, but I sometimes
escape one when its presence "gets in the way" of my browsing the code
with `outline-minor-mode`.
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: master 1870e2f48a7: Avoid `defconst` for vars which we modify
2024-01-06 21:47 ` Stefan Monnier
@ 2024-01-07 8:39 ` Michael Albinus
0 siblings, 0 replies; 7+ messages in thread
From: Michael Albinus @ 2024-01-07 8:39 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
Hi Stefan,
>> Well, we're speaking 'bout Tramp Lisp files. I don't see how they will
>> be affected by `outline-minor-mode`.
>
> I use `outline-minor-mode` for `emacs-lisp-mode`.
> I don't go around escaping all the ( that are out there, but I sometimes
> escape one when its presence "gets in the way" of my browsing the code
> with `outline-minor-mode`.
Understood. I keep it as-it-is.
> Stefan
Best regards, Michael.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-01-07 8:39 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <170441189460.14171.1535755350269345875@vcs2.savannah.gnu.org>
[not found] ` <20240104234455.0F58DC00344@vcs2.savannah.gnu.org>
2024-01-06 12:55 ` master 1870e2f48a7: Avoid `defconst` for vars which we modify Michael Albinus
2024-01-06 13:16 ` Po Lu
2024-01-06 13:32 ` Michael Albinus
2024-01-06 16:23 ` Stefan Monnier
2024-01-06 16:48 ` Michael Albinus
2024-01-06 21:47 ` Stefan Monnier
2024-01-07 8:39 ` Michael Albinus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).